Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactiveObjC: upgrade deployment target to 12.0 and eliminate Xcode12 warnings. #40

Merged
merged 10 commits into from
Aug 27, 2020
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: 2
jobs:
build:
macos:
xcode: "10.0.0"
xcode: "12.0.0"

steps:
- checkout
Expand Down
4 changes: 2 additions & 2 deletions Cartfile.private
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
github "jspahrsummers/xcconfigs" "3d9d996"
github "Quick/Quick" ~> 1.3.2
github "Quick/Nimble" ~> 7.3.1
github "Quick/Quick" ~> 3.0.0
github "Quick/Nimble" ~> 8.1.1
4 changes: 2 additions & 2 deletions Cartfile.resolved
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
github "Quick/Nimble" "v7.3.1"
github "Quick/Quick" "v1.3.2"
github "Quick/Nimble" "v8.1.1"
github "Quick/Quick" "v3.0.0"
github "jspahrsummers/xcconfigs" "3d9d99634cae6d586e272543d527681283b33eb0"
2 changes: 1 addition & 1 deletion Carthage/Checkouts/Nimble
Submodule Nimble updated 128 files
2 changes: 1 addition & 1 deletion Carthage/Checkouts/Quick
Submodule Quick updated 98 files
+1 −1 .github/ISSUE_TEMPLATE
+52 −0 .github/workflows/ci.yml
+15 −0 .github/workflows/swiftlint.yml
+0 −2 .hound.yml
+0 −1 .swift-version
+7 −4 .swiftlint.yml
+35 −50 .travis.yml
+1 −1 CONTRIBUTING.md
+3 −7 Dangerfile
+24 −2 Documentation/en-us/InstallingQuick.md
+72 −3 Documentation/en-us/SharedExamples.md
+1 −1 Documentation/ja/InstallingQuick.md
+4 −4 Documentation/ja/SharedExamples.md
+1 −1 Documentation/ko-kr/BehavioralTesting.md
+2 −2 Documentation/ko-kr/InstallingQuick.md
+3 −3 Documentation/ko-kr/SharedExamples.md
+4 −4 Documentation/pt-br/SharedExamples.md
+1 −1 Documentation/zh-cn/InstallingQuick.md
+3 −3 Documentation/zh-cn/SharedExamples.md
+1 −1 Externals/Nimble
+1 −2 Gemfile
+80 −60 Gemfile.lock
+20 −2 Package.resolved
+39 −37 Package.swift
+0 −40 [email protected]
+1 −1 Quick Templates/Quick Configuration Class.xctemplate/Objective-C/___FILEBASENAME___.h
+1 −1 Quick Templates/Quick Configuration Class.xctemplate/Objective-C/___FILEBASENAME___.m
+1 −1 Quick Templates/Quick Configuration Class.xctemplate/Swift/___FILEBASENAME___.swift
+3 −3 Quick Templates/Quick Spec Class.xctemplate/Objective-C/___FILEBASENAME___.m
+1 −1 Quick Templates/Quick Spec Class.xctemplate/Swift/___FILEBASENAME___.swift
+10 −3 Quick.podspec
+243 −353 Quick.xcodeproj/project.pbxproj
+1 −1 Quick.xcodeproj/xcshareddata/xcschemes/Quick-iOS.xcscheme
+20 −14 Quick.xcodeproj/xcshareddata/xcschemes/Quick-macOS.xcscheme
+1 −1 Quick.xcodeproj/xcshareddata/xcschemes/Quick-tvOS.xcscheme
+8 −0 Quick.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings
+4 −1 README.md
+8 −7 Rakefile
+8 −6 Sources/Quick/Behavior.swift
+19 −12 Sources/Quick/Callsite.swift
+24 −20 Sources/Quick/Configuration/Configuration.swift
+59 −20 Sources/Quick/Configuration/QuickConfiguration.swift
+16 −12 Sources/Quick/DSL/DSL.swift
+25 −24 Sources/Quick/DSL/World+DSL.swift
+1 −1 Sources/Quick/ErrorUtility.swift
+27 −23 Sources/Quick/Example.swift
+7 −0 Sources/Quick/ExampleGroup.swift
+5 −9 Sources/Quick/ExampleMetadata.swift
+5 −9 Sources/Quick/Filter.swift
+2 −2 Sources/Quick/NSBundle+CurrentTestBundle.swift
+3 −10 Sources/Quick/QuickMain.swift
+1 −1 Sources/Quick/QuickSelectedTestSuiteBuilder.swift
+69 −52 Sources/Quick/QuickSpec.swift
+69 −0 Sources/Quick/QuickTestObservation.swift
+1 −1 Sources/Quick/QuickTestSuite.swift
+5 −8 Sources/Quick/String+C99ExtendedIdentifier.swift
+43 −27 Sources/Quick/World.swift
+5 −22 Sources/QuickObjCRuntime/QuickSpecBase.m
+7 −0 Sources/QuickObjCRuntime/include/QuickSpecBase.h
+2 −43 Sources/QuickObjectiveC/Configuration/QuickConfiguration.m
+1 −1 Sources/QuickObjectiveC/QuickSpec.h
+55 −37 Sources/QuickObjectiveC/QuickSpec.m
+0 −11 Sources/QuickSpecBase/include/QuickSpecBase.h
+5 −0 Tests/.swiftlint.yml
+17 −15 Tests/LinuxMain.swift
+20 −0 Tests/QuickIssue853RegressionTests/SubclassOfSubclassWithStructPropertyTests.swift
+13 −2 Tests/QuickTests/QuickFocusedTests/FocusedTests.swift
+0 −30 Tests/QuickTests/QuickTestHelpers/SpecRunner.swift
+0 −9 Tests/QuickTests/QuickTestHelpers/TestRun.swift
+5 −5 Tests/QuickTests/QuickTestHelpers/XCTestCaseProvider.swift
+6 −6 Tests/QuickTests/QuickTests/FunctionalTests/AfterEachTests.swift
+4 −4 Tests/QuickTests/QuickTests/FunctionalTests/BeforeEachTests.swift
+3 −3 Tests/QuickTests/QuickTests/FunctionalTests/BeforeSuiteTests.swift
+4 −6 Tests/QuickTests/QuickTests/FunctionalTests/BehaviorTests.swift
+1 −1 Tests/QuickTests/QuickTests/FunctionalTests/Configuration/AfterEach/Configuration+AfterEachTests.swift
+1 −1 Tests/QuickTests/QuickTests/FunctionalTests/Configuration/BeforeEach/Configuration+BeforeEachTests.swift
+2 −2 Tests/QuickTests/QuickTests/FunctionalTests/ContextTests.swift
+18 −6 Tests/QuickTests/QuickTests/FunctionalTests/CurrentSpecTests.swift
+3 −3 Tests/QuickTests/QuickTests/FunctionalTests/DescribeTests.swift
+64 −14 Tests/QuickTests/QuickTests/FunctionalTests/ItTests.swift
+1 −1 Tests/QuickTests/QuickTests/FunctionalTests/ObjC/ItTests+ObjC.m
+13 −1 Tests/QuickTests/QuickTests/FunctionalTests/PendingTests.swift
+52 −0 Tests/QuickTests/QuickTests/FunctionalTests/QuickSpec_SelectedTests.swift
+1 −1 Tests/QuickTests/QuickTests/FunctionalTests/SharedExamples+BeforeEachTests.swift
+3 −3 Tests/QuickTests/QuickTests/FunctionalTests/SharedExamplesTests.swift
+8 −23 Tests/QuickTests/QuickTests/Helpers/QCKSpecRunner.m
+24 −0 Tests/QuickTests/QuickTests/Helpers/QuickSpec+MethodList.swift
+0 −17 Tests/QuickTests/QuickTests/Helpers/QuickSpec+QuickSpec_MethodList.h
+0 −23 Tests/QuickTests/QuickTests/Helpers/QuickSpec+QuickSpec_MethodList.m
+101 −0 Tests/QuickTests/QuickTests/Helpers/QuickSpecRunner.swift
+1 −2 Tests/QuickTests/QuickTests/Helpers/QuickTestsBridgingHeader.h
+0 −20 Tests/QuickTests/QuickTests/Helpers/XCTestObservationCenter+QCKSuspendObservation.h
+0 −54 Tests/QuickTests/QuickTests/Helpers/XCTestObservationCenter+QCKSuspendObservation.m
+64 −0 Tests/QuickTests/QuickTests/Helpers/XCTestObservationCenter+QCKSuspendObservation.swift
+1 −1 script/release
+0 −5 script/travis-install-linux
+0 −4 script/travis-install-macos
+0 −4 script/travis-script-linux
43 changes: 11 additions & 32 deletions ReactiveObjC.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -568,10 +568,6 @@
D037661319EDA41200A782A9 /* RACUnit.m in Sources */ = {isa = PBXBuildFile; fileRef = D03764BF19EDA41200A782A9 /* RACUnit.m */; };
D037661619EDA41200A782A9 /* RACValueTransformer.m in Sources */ = {isa = PBXBuildFile; fileRef = D03764C119EDA41200A782A9 /* RACValueTransformer.m */; };
D037661719EDA41200A782A9 /* RACValueTransformer.m in Sources */ = {isa = PBXBuildFile; fileRef = D03764C119EDA41200A782A9 /* RACValueTransformer.m */; };
D037661919EDA41200A782A9 /* UIActionSheet+RACSignalSupport.h in Headers */ = {isa = PBXBuildFile; fileRef = D03764C219EDA41200A782A9 /* UIActionSheet+RACSignalSupport.h */; settings = {ATTRIBUTES = (Public, ); }; };
D037661B19EDA41200A782A9 /* UIActionSheet+RACSignalSupport.m in Sources */ = {isa = PBXBuildFile; fileRef = D03764C319EDA41200A782A9 /* UIActionSheet+RACSignalSupport.m */; };
D037661D19EDA41200A782A9 /* UIAlertView+RACSignalSupport.h in Headers */ = {isa = PBXBuildFile; fileRef = D03764C419EDA41200A782A9 /* UIAlertView+RACSignalSupport.h */; settings = {ATTRIBUTES = (Public, ); }; };
D037661F19EDA41200A782A9 /* UIAlertView+RACSignalSupport.m in Sources */ = {isa = PBXBuildFile; fileRef = D03764C519EDA41200A782A9 /* UIAlertView+RACSignalSupport.m */; };
D037662119EDA41200A782A9 /* UIBarButtonItem+RACCommandSupport.h in Headers */ = {isa = PBXBuildFile; fileRef = D03764C619EDA41200A782A9 /* UIBarButtonItem+RACCommandSupport.h */; settings = {ATTRIBUTES = (Public, ); }; };
D037662319EDA41200A782A9 /* UIBarButtonItem+RACCommandSupport.m in Sources */ = {isa = PBXBuildFile; fileRef = D03764C719EDA41200A782A9 /* UIBarButtonItem+RACCommandSupport.m */; };
D037662519EDA41200A782A9 /* UIButton+RACCommandSupport.h in Headers */ = {isa = PBXBuildFile; fileRef = D03764C819EDA41200A782A9 /* UIButton+RACCommandSupport.h */; settings = {ATTRIBUTES = (Public, ); }; };
Expand Down Expand Up @@ -692,8 +688,6 @@
D037671619EDA60000A782A9 /* RACTupleSpec.m in Sources */ = {isa = PBXBuildFile; fileRef = D03766B019EDA60000A782A9 /* RACTupleSpec.m */; };
D037671719EDA60000A782A9 /* test-data.json in Resources */ = {isa = PBXBuildFile; fileRef = D03766B119EDA60000A782A9 /* test-data.json */; };
D037671819EDA60000A782A9 /* test-data.json in Resources */ = {isa = PBXBuildFile; fileRef = D03766B119EDA60000A782A9 /* test-data.json */; };
D037671A19EDA60000A782A9 /* UIActionSheetRACSupportSpec.m in Sources */ = {isa = PBXBuildFile; fileRef = D03766B219EDA60000A782A9 /* UIActionSheetRACSupportSpec.m */; };
D037671C19EDA60000A782A9 /* UIAlertViewRACSupportSpec.m in Sources */ = {isa = PBXBuildFile; fileRef = D03766B319EDA60000A782A9 /* UIAlertViewRACSupportSpec.m */; };
D037671E19EDA60000A782A9 /* UIBarButtonItemRACSupportSpec.m in Sources */ = {isa = PBXBuildFile; fileRef = D03766B419EDA60000A782A9 /* UIBarButtonItemRACSupportSpec.m */; };
D037672019EDA60000A782A9 /* UIButtonRACSupportSpec.m in Sources */ = {isa = PBXBuildFile; fileRef = D03766B519EDA60000A782A9 /* UIButtonRACSupportSpec.m */; };
D037672419EDA60000A782A9 /* UIImagePickerControllerRACSupportSpec.m in Sources */ = {isa = PBXBuildFile; fileRef = D03766B719EDA60000A782A9 /* UIImagePickerControllerRACSupportSpec.m */; };
Expand Down Expand Up @@ -938,10 +932,6 @@
D03764BF19EDA41200A782A9 /* RACUnit.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = RACUnit.m; sourceTree = "<group>"; };
D03764C019EDA41200A782A9 /* RACValueTransformer.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RACValueTransformer.h; sourceTree = "<group>"; };
D03764C119EDA41200A782A9 /* RACValueTransformer.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = RACValueTransformer.m; sourceTree = "<group>"; };
D03764C219EDA41200A782A9 /* UIActionSheet+RACSignalSupport.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "UIActionSheet+RACSignalSupport.h"; sourceTree = "<group>"; };
D03764C319EDA41200A782A9 /* UIActionSheet+RACSignalSupport.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "UIActionSheet+RACSignalSupport.m"; sourceTree = "<group>"; };
D03764C419EDA41200A782A9 /* UIAlertView+RACSignalSupport.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "UIAlertView+RACSignalSupport.h"; sourceTree = "<group>"; };
D03764C519EDA41200A782A9 /* UIAlertView+RACSignalSupport.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "UIAlertView+RACSignalSupport.m"; sourceTree = "<group>"; };
D03764C619EDA41200A782A9 /* UIBarButtonItem+RACCommandSupport.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "UIBarButtonItem+RACCommandSupport.h"; sourceTree = "<group>"; };
D03764C719EDA41200A782A9 /* UIBarButtonItem+RACCommandSupport.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "UIBarButtonItem+RACCommandSupport.m"; sourceTree = "<group>"; };
D03764C819EDA41200A782A9 /* UIButton+RACCommandSupport.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "UIButton+RACCommandSupport.h"; sourceTree = "<group>"; };
Expand Down Expand Up @@ -1029,8 +1019,6 @@
D03766A819EDA60000A782A9 /* RACTargetQueueSchedulerSpec.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = RACTargetQueueSchedulerSpec.m; sourceTree = "<group>"; };
D03766B019EDA60000A782A9 /* RACTupleSpec.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = RACTupleSpec.m; sourceTree = "<group>"; };
D03766B119EDA60000A782A9 /* test-data.json */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.json; path = "test-data.json"; sourceTree = "<group>"; };
D03766B219EDA60000A782A9 /* UIActionSheetRACSupportSpec.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = UIActionSheetRACSupportSpec.m; sourceTree = "<group>"; };
D03766B319EDA60000A782A9 /* UIAlertViewRACSupportSpec.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = UIAlertViewRACSupportSpec.m; sourceTree = "<group>"; };
D03766B419EDA60000A782A9 /* UIBarButtonItemRACSupportSpec.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = UIBarButtonItemRACSupportSpec.m; sourceTree = "<group>"; };
D03766B519EDA60000A782A9 /* UIButtonRACSupportSpec.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = UIButtonRACSupportSpec.m; sourceTree = "<group>"; };
D03766B719EDA60000A782A9 /* UIImagePickerControllerRACSupportSpec.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = UIImagePickerControllerRACSupportSpec.m; sourceTree = "<group>"; };
Expand Down Expand Up @@ -1363,10 +1351,6 @@
D03764C119EDA41200A782A9 /* RACValueTransformer.m */,
D04725EF19E49ED7006002AA /* ReactiveObjC.h */,
D04725ED19E49ED7006002AA /* Supporting Files */,
D03764C219EDA41200A782A9 /* UIActionSheet+RACSignalSupport.h */,
D03764C319EDA41200A782A9 /* UIActionSheet+RACSignalSupport.m */,
D03764C419EDA41200A782A9 /* UIAlertView+RACSignalSupport.h */,
D03764C519EDA41200A782A9 /* UIAlertView+RACSignalSupport.m */,
D03764C619EDA41200A782A9 /* UIBarButtonItem+RACCommandSupport.h */,
D03764C719EDA41200A782A9 /* UIBarButtonItem+RACCommandSupport.m */,
D03764C819EDA41200A782A9 /* UIButton+RACCommandSupport.h */,
Expand Down Expand Up @@ -1465,8 +1449,6 @@
D03766A719EDA60000A782A9 /* RACSubscriptingAssignmentTrampolineSpec.m */,
D03766A819EDA60000A782A9 /* RACTargetQueueSchedulerSpec.m */,
D03766B019EDA60000A782A9 /* RACTupleSpec.m */,
D03766B219EDA60000A782A9 /* UIActionSheetRACSupportSpec.m */,
D03766B319EDA60000A782A9 /* UIAlertViewRACSupportSpec.m */,
D03766B419EDA60000A782A9 /* UIBarButtonItemRACSupportSpec.m */,
D03766B519EDA60000A782A9 /* UIButtonRACSupportSpec.m */,
D03766B719EDA60000A782A9 /* UIImagePickerControllerRACSupportSpec.m */,
Expand Down Expand Up @@ -1768,7 +1750,6 @@
D037656F19EDA41200A782A9 /* RACDisposable.h in Headers */,
314304171ACA8B1E00595017 /* MKAnnotationView+RACSignalSupport.h in Headers */,
D037654519EDA41200A782A9 /* NSURLConnection+RACSupport.h in Headers */,
D037661D19EDA41200A782A9 /* UIAlertView+RACSignalSupport.h in Headers */,
D037650D19EDA41200A782A9 /* NSNotificationCenter+RACSupport.h in Headers */,
D037650119EDA41200A782A9 /* NSFileHandle+RACSupport.h in Headers */,
D037666119EDA41200A782A9 /* UITextView+RACSignalSupport.h in Headers */,
Expand Down Expand Up @@ -1818,7 +1799,6 @@
A1046B7B1BFF5662004D8045 /* EXTRuntimeExtensions.h in Headers */,
D037661119EDA41200A782A9 /* RACUnit.h in Headers */,
D03765FD19EDA41200A782A9 /* RACTargetQueueScheduler.h in Headers */,
D037661919EDA41200A782A9 /* UIActionSheet+RACSignalSupport.h in Headers */,
D037664D19EDA41200A782A9 /* UIStepper+RACSignalSupport.h in Headers */,
D037662119EDA41200A782A9 /* UIBarButtonItem+RACCommandSupport.h in Headers */,
D03765EB19EDA41200A782A9 /* RACSubject.h in Headers */,
Expand Down Expand Up @@ -2441,7 +2421,6 @@
D037662B19EDA41200A782A9 /* UICollectionReusableView+RACSignalSupport.m in Sources */,
D037659919EDA41200A782A9 /* RACIndexSetSequence.m in Sources */,
D03765D919EDA41200A782A9 /* RACSignal+Operations.m in Sources */,
D037661B19EDA41200A782A9 /* UIActionSheet+RACSignalSupport.m in Sources */,
D037650319EDA41200A782A9 /* NSFileHandle+RACSupport.m in Sources */,
D03765E319EDA41200A782A9 /* RACStream.m in Sources */,
D037655719EDA41200A782A9 /* RACBehaviorSubject.m in Sources */,
Expand All @@ -2457,7 +2436,6 @@
D03764FB19EDA41200A782A9 /* NSDictionary+RACSequenceAdditions.m in Sources */,
D037656919EDA41200A782A9 /* RACCompoundDisposableProvider.d in Sources */,
D037653B19EDA41200A782A9 /* NSString+RACSequenceAdditions.m in Sources */,
D037661F19EDA41200A782A9 /* UIAlertView+RACSignalSupport.m in Sources */,
D03765E919EDA41200A782A9 /* RACStringSequence.m in Sources */,
D037660B19EDA41200A782A9 /* RACTupleSequence.m in Sources */,
D03765D519EDA41200A782A9 /* RACSignal.m in Sources */,
Expand Down Expand Up @@ -2556,7 +2534,6 @@
D0C3132119EF2D9700984962 /* RACTestObject.m in Sources */,
D03766FC19EDA60000A782A9 /* RACSignalSpec.m in Sources */,
D037670819EDA60000A782A9 /* RACSubscriberSpec.m in Sources */,
D037671C19EDA60000A782A9 /* UIAlertViewRACSupportSpec.m in Sources */,
D03766F019EDA60000A782A9 /* RACPropertySignalExamples.m in Sources */,
D037670619EDA60000A782A9 /* RACSubscriberExamples.m in Sources */,
D03766D819EDA60000A782A9 /* RACBlockTrampolineSpec.m in Sources */,
Expand All @@ -2570,7 +2547,6 @@
D03766E619EDA60000A782A9 /* RACDisposableSpec.m in Sources */,
D03766D419EDA60000A782A9 /* NSUserDefaultsRACSupportSpec.m in Sources */,
D03766DC19EDA60000A782A9 /* RACChannelSpec.m in Sources */,
D037671A19EDA60000A782A9 /* UIActionSheetRACSupportSpec.m in Sources */,
D03766DA19EDA60000A782A9 /* RACChannelExamples.m in Sources */,
8B33C24021CBD31800BB82D2 /* RACNeverSignalSpec.m in Sources */,
D03766F619EDA60000A782A9 /* RACSequenceExamples.m in Sources */,
Expand Down Expand Up @@ -2790,17 +2766,18 @@
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
CLANG_WARN_COMMA = YES;
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_STRICT_PROTOTYPES = YES;
CODE_SIGNING_REQUIRED = NO;
CURRENT_PROJECT_VERSION = 1;
ENABLE_TESTABILITY = YES;
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
MACOSX_DEPLOYMENT_TARGET = 10.9;
PRODUCT_BUNDLE_IDENTIFIER = "org.reactivecocoa.$(PRODUCT_NAME:rfc1034identifier)";
PRODUCT_NAME = "$(PROJECT_NAME)";
RUN_CLANG_STATIC_ANALYZER = NO;
TVOS_DEPLOYMENT_TARGET = 9.0;
TVOS_DEPLOYMENT_TARGET = 12.0;
VERSIONING_SYSTEM = "apple-generic";
VERSION_INFO_PREFIX = "";
WARNING_CFLAGS = (
Expand All @@ -2824,12 +2801,12 @@
CODE_SIGNING_REQUIRED = NO;
CURRENT_PROJECT_VERSION = 1;
GCC_OPTIMIZATION_LEVEL = 0;
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
MACOSX_DEPLOYMENT_TARGET = 10.9;
PRODUCT_BUNDLE_IDENTIFIER = "org.reactivecocoa.$(PRODUCT_NAME:rfc1034identifier)";
PRODUCT_NAME = "$(PROJECT_NAME)";
RUN_CLANG_STATIC_ANALYZER = NO;
TVOS_DEPLOYMENT_TARGET = 9.0;
TVOS_DEPLOYMENT_TARGET = 12.0;
VERSIONING_SYSTEM = "apple-generic";
VERSION_INFO_PREFIX = "";
WARNING_CFLAGS = (
Expand Down Expand Up @@ -2927,6 +2904,7 @@
baseConfigurationReference = D047263219E49FE8006002AA /* iOS-Application.xcconfig */;
buildSettings = {
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = NO;
INFOPLIST_FILE = ReactiveObjCTests/Info.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_NAME = "$(PROJECT_NAME)Tests";
Expand All @@ -2952,16 +2930,17 @@
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
CLANG_WARN_COMMA = YES;
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_STRICT_PROTOTYPES = YES;
CODE_SIGNING_REQUIRED = NO;
CURRENT_PROJECT_VERSION = 1;
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
MACOSX_DEPLOYMENT_TARGET = 10.9;
PRODUCT_BUNDLE_IDENTIFIER = "org.reactivecocoa.$(PRODUCT_NAME:rfc1034identifier)";
PRODUCT_NAME = "$(PROJECT_NAME)";
RUN_CLANG_STATIC_ANALYZER = NO;
TVOS_DEPLOYMENT_TARGET = 9.0;
TVOS_DEPLOYMENT_TARGET = 12.0;
VERSIONING_SYSTEM = "apple-generic";
VERSION_INFO_PREFIX = "";
WARNING_CFLAGS = (
Expand Down Expand Up @@ -3036,12 +3015,12 @@
CLANG_WARN_STRICT_PROTOTYPES = YES;
CODE_SIGNING_REQUIRED = NO;
CURRENT_PROJECT_VERSION = 1;
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
MACOSX_DEPLOYMENT_TARGET = 10.9;
PRODUCT_BUNDLE_IDENTIFIER = "org.reactivecocoa.$(PRODUCT_NAME:rfc1034identifier)-Tests";
PRODUCT_NAME = "$(PROJECT_NAME)";
RUN_CLANG_STATIC_ANALYZER = NO;
TVOS_DEPLOYMENT_TARGET = 9.0;
TVOS_DEPLOYMENT_TARGET = 12.0;
VERSIONING_SYSTEM = "apple-generic";
VERSION_INFO_PREFIX = "";
WARNING_CFLAGS = (
Expand Down
2 changes: 1 addition & 1 deletion ReactiveObjC/NSObject+RACPropertySubscribing.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

#import <Foundation/Foundation.h>
#import <ReactiveObjC/EXTKeyPathCoding.h>
#import "metamacros.h"
#import <ReactiveObjC/metamacros.h>

/// Creates a signal which observes `KEYPATH` on `TARGET` for changes.
///
Expand Down
1 change: 0 additions & 1 deletion ReactiveObjC/NSObject+RACPropertySubscribing.m
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#import "RACSubscriber.h"
#import "RACSignal+Operations.h"
#import "RACTuple.h"
#import <libkern/OSAtomic.h>

@implementation NSObject (RACPropertySubscribing)

Expand Down
2 changes: 1 addition & 1 deletion ReactiveObjC/RACBehaviorSubject.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// Copyright (c) 2012 GitHub, Inc. All rights reserved.
//

#import "RACSubject.h"
#import <ReactiveObjC/RACSubject.h>

NS_ASSUME_NONNULL_BEGIN

Expand Down
4 changes: 2 additions & 2 deletions ReactiveObjC/RACChannel.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
// Copyright (c) 2013 GitHub, Inc. All rights reserved.
//

#import "RACSignal.h"
#import "RACSubscriber.h"
#import <ReactiveObjC/RACSignal.h>
#import <ReactiveObjC/RACSubscriber.h>

@class RACChannelTerminal<ValueType>;

Expand Down
8 changes: 4 additions & 4 deletions ReactiveObjC/RACCommand.m
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
#import "RACScheduler.h"
#import "RACSequence.h"
#import "RACSignal+Operations.h"
#import <libkern/OSAtomic.h>
#import <stdatomic.h>

NSString * const RACCommandErrorDomain = @"RACCommandErrorDomain";
NSString * const RACUnderlyingCommandErrorKey = @"RACUnderlyingCommandErrorKey";
Expand All @@ -26,7 +26,7 @@

@interface RACCommand () {
// Atomic backing variable for `allowsConcurrentExecution`.
volatile uint32_t _allowsConcurrentExecution;
atomic_bool _allowsConcurrentExecution;
}

/// A subject that sends added execution signals.
Expand Down Expand Up @@ -55,9 +55,9 @@ - (BOOL)allowsConcurrentExecution {

- (void)setAllowsConcurrentExecution:(BOOL)allowed {
if (allowed) {
OSAtomicOr32Barrier(1, &_allowsConcurrentExecution);
_allowsConcurrentExecution = true;
} else {
OSAtomicAnd32Barrier(0, &_allowsConcurrentExecution);
_allowsConcurrentExecution = false;
}

[self.allowsConcurrentExecutionSubject sendNext:@(_allowsConcurrentExecution)];
Expand Down
2 changes: 1 addition & 1 deletion ReactiveObjC/RACCompoundDisposable.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// Copyright (c) 2012 GitHub, Inc. All rights reserved.
//

#import "RACDisposable.h"
#import <ReactiveObjC/RACDisposable.h>

NS_ASSUME_NONNULL_BEGIN

Expand Down
12 changes: 6 additions & 6 deletions ReactiveObjC/RACDisposable.m
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@

#import "RACDisposable.h"
#import "RACScopedDisposable.h"
#import <libkern/OSAtomic.h>
#import <stdatomic.h>

@interface RACDisposable () {
// A copied block of type void (^)(void) containing the logic for disposal,
// a pointer to `self` if no logic should be performed upon disposal, or
// NULL if the receiver is already disposed.
//
// This should only be used atomically.
void * volatile _disposeBlock;
_Atomic(void *) _disposeBlock;
}

@end
Expand All @@ -35,7 +35,7 @@ - (instancetype)init {
self = [super init];

_disposeBlock = (__bridge void *)self;
OSMemoryBarrier();
atomic_thread_fence(memory_order_seq_cst);

return self;
}
Expand All @@ -45,8 +45,8 @@ - (instancetype)initWithBlock:(void (^)(void))block {

self = [super init];

_disposeBlock = (void *)CFBridgingRetain([block copy]);
OSMemoryBarrier();
_disposeBlock = (void *)CFBridgingRetain([block copy]);
atomic_thread_fence(memory_order_seq_cst);

return self;
}
Expand All @@ -69,7 +69,7 @@ - (void)dispose {

while (YES) {
void *blockPtr = _disposeBlock;
if (OSAtomicCompareAndSwapPtrBarrier(blockPtr, NULL, &_disposeBlock)) {
if (atomic_compare_exchange_strong(&_disposeBlock, &blockPtr, NULL)) {
if (blockPtr != (__bridge void *)self) {
disposeBlock = CFBridgingRelease(blockPtr);
}
Expand Down
8 changes: 4 additions & 4 deletions ReactiveObjC/RACDynamicSequence.m
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
//

#import "RACDynamicSequence.h"
#import <libkern/OSAtomic.h>
#import <stdatomic.h>

// Determines how RACDynamicSequences will be deallocated before the next one is
// shifted onto the autorelease pool.
Expand Down Expand Up @@ -114,10 +114,10 @@ + (RACSequence *)sequenceWithLazyDependency:(id (^)(void))dependencyBlock headBl
}

- (void)dealloc {
static volatile int32_t directDeallocCount = 0;
static atomic_int directDeallocCount = 0;

if (OSAtomicIncrement32(&directDeallocCount) >= DEALLOC_OVERFLOW_GUARD) {
OSAtomicAdd32(-DEALLOC_OVERFLOW_GUARD, &directDeallocCount);
if (atomic_fetch_add(&directDeallocCount, 1) + 1 >= DEALLOC_OVERFLOW_GUARD) {
atomic_fetch_add(&directDeallocCount, -DEALLOC_OVERFLOW_GUARD);

// Put this sequence's tail onto the autorelease pool so we stop
// recursing.
Expand Down
1 change: 0 additions & 1 deletion ReactiveObjC/RACDynamicSignal.m
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
#import "RACPassthroughSubscriber.h"
#import "RACScheduler+Private.h"
#import "RACSubscriber.h"
#import <libkern/OSAtomic.h>

@interface RACDynamicSignal ()

Expand Down
2 changes: 1 addition & 1 deletion ReactiveObjC/RACGroupedSignal.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// Copyright (c) 2012 GitHub, Inc. All rights reserved.
//

#import "RACSubject.h"
#import <ReactiveObjC/RACSubject.h>

NS_ASSUME_NONNULL_BEGIN

Expand Down
4 changes: 2 additions & 2 deletions ReactiveObjC/RACKVOChannel.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
// Copyright (c) 2012 GitHub, Inc. All rights reserved.
//

#import "RACChannel.h"
#import <ReactiveObjC/RACChannel.h>
#import <ReactiveObjC/EXTKeyPathCoding.h>
#import "metamacros.h"
#import <ReactiveObjC/metamacros.h>

/// Creates a RACKVOChannel to the given key path. When the targeted object
/// deallocates, the channel will complete.
Expand Down
Loading