assignment :서연진#7
Open
shtfh wants to merge 1 commit intoLikeLion-13th-SKHU:mainfrom
Open
Conversation
wjdekdns1028
reviewed
Nov 9, 2025
wjdekdns1028
left a comment
wjdekdns1028
left a comment
There was a problem hiding this comment.
과제 통과입니다!!🥳
해커톤에서 경험해 보고 쉽게 과제를 수행하셨다니 너무 뿌듯하네요!!
이렇게 하나하나 경험을 쌓아가며 열심히 해주시는 게 멋지십니당!!
앞으로도 화이팅입니다!!
수고하셨어용~~
| .findFirst() | ||
| .orElseThrow(() -> new RuntimeException("해당 키 ID에 대한 JWK를 찾을 수 없습니다: " + keyId)); | ||
| } catch (Exception exception) { | ||
| throw new RuntimeException("Google JWK를 가져오는데 실패했습니다: " + exception.getMessage()); |
There was a problem hiding this comment.
현재 모든 예외를 RuntimeException으로 감싸 반환하는데 좀 더 명확하게 예외 구분을 하면 좋을 것 같습니당!!
| private final MemberRepository memberRepository; | ||
|
|
||
| @Value("${token.expire.time}") // factory annotation 임포트 | ||
| private String tokenExpireTime; // 토큰 만료 시간 |
There was a problem hiding this comment.
여기서 String을 사용하면 매번 숫자로 변환해야하는 불편함이 있는 것 같아요..
Duration은 시간을 표현하기 위한 자바 표준 클래스입니다!!
이런 부분에서 Duration을 사용하면 형 변환에서 오는 오류가 없어지고 유지보수가 쉬워지기도 한다고 하니 한 번 사용해보는 것도 좋을 것 같네용!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
<!— 구현 및 과제 내용을 적어주세요(지우고 작성해주세요) —>
-IdToken 구현
-Kakao 소셜 로그인 구현
Important content
<!— 주의 깊게 봐줬으면 하는 부분을 적어주세요(지우고 작성해주세요) —>
Question
<!— 궁금한 점을 적어주세요(지우고 작성해주세요) —>
Reference
<!— 참고한 레퍼런스가 있다면 공유해 주세요(지우고 작성해주세요) —>
Image