fix: stop normalizeMoneyAmount from silently truncating sub-cent Stellar amounts (Closes #439) - #464
Merged
David-patrick-chuks-02 merged 2 commits intoSep 6, 2026
Conversation
David-patrick-chuks-02
marked this pull request as ready for review
September 6, 2026 09:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #439 by making
normalizeMoneyAmountprecision-aware instead of hard-coding 2 decimal places.Key Changes
'0.0000001'and'0.0000009'from silently truncating to'0.00'.scaleparameter (0-7) andNormalizeMoneyAmountOptionswith optionalround: booleanflag.'0075.5'->'75.50').RangeErrorifscale < 0,scale > 7, or!Number.isInteger(scale).tests/money-amount.test.tsfor sub-cent amounts, custom scale, half-up rounding,RangeErrorboundaries, and compatibility withvalidateMoneyAmount.Verification
npx vitest run tests/money-amount.test.ts tests/request-validation.test.ts: Passed (22/22 tests).npx vitest run tests/models.test.ts tests/moneyamount-passthrough.test.ts tests/public-api-types.test.ts tests/validation.test.ts tests/payment-validation.test.ts: Passed (63/63 tests).npx prettier --check src/models/common.ts tests/money-amount.test.ts: Passed.npx eslint src/models/common.ts tests/money-amount.test.ts: Passed (0 errors, 0 warnings).npx tsup: Build succeeded (ESM, CJS, and DTS bundles emitted).Payout Routing
0xF46C9F6d70C50BF81ef3588AB523a90a594a2F89GCL6OXAMLD75BMTINA6EMRUDWK5THQUSHMYNLSNBCJAPZJHNYJTUNIBC