docs: align Node.js version claims with engines and CI (Closes #453) - #545
Merged
David-patrick-chuks-02 merged 2 commits intoSep 6, 2026
Conversation
Reconcile README, runtime-requirements, and package engines (>=20) with the CI matrix (20/22/24). Drop stale Node 18 support claims and add a regression test that parses the workflow matrix. Closes Lilly-Protocol#453
# Conflicts: # docs/runtime-requirements.md # tests/ci-matrix-node24.test.ts
David-patrick-chuks-02
merged commit Sep 6, 2026
5949ac8
into
Lilly-Protocol:main
0 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #453 by aligning Node.js support claims across README,
docs/runtime-requirements.md,package.jsonengines (>=20.0.0), and the CI matrix in.github/workflows/ci.yml(20/22/24).Changes
>=20.0.0); recommended Node.js 22 LTS; tested versions match CI; explicitly notes Node.js 18 is not supported; fetch wording updated to Node 20+.node-version: [...]fromci.ymland asserts README + runtime docs stay in sync with engines and that matrix (differentiates from hard-coded string-only checks).Why this differs from open #456 / #526
Those PRs update the same docs with similar wording. This PR additionally:
.github/workflows/ci.yml.>=20.0.0) in the runtime docs.Validation
npx vitest run tests/ci-matrix-node24.test.tsCloses #453