fix: validate per-request timeoutMs in fetch client - #557
Merged
David-patrick-chuks-02 merged 1 commit intoSep 6, 2026
Merged
Conversation
- Reject negative, NaN, Infinity, and non-number timeoutMs values - Allow 0 (opt-out) and positive values - Mirror config-level validation message - Add comprehensive unit tests Addresses bounty: Lilly-Protocol#446 Payment address: 0x047b2A7fc72862a0e3E772eb53b19d35929BEd46 (Base/EVM, USDC/BUSD BEP20)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds validation for the per-request
timeoutMsoption in the fetch HTTP client.Problem
client.request({ ..., timeoutMs: -1 })andNaN/string values would be passed through without validation, leading to silently-firing or never-firing timers instead of clear error messages.Solution
Validate
request.timeoutMsbefore the request loop starts:LilyConfigError0(documented opt-out for disabling timeout)Mirrors the existing config-level
timeoutMsvalidation inresolve-config.ts.Testing
Added comprehensive unit tests in
tests/request-timeout-validation.test.ts:Related Issue
Closes #446
Payment
Wallet:
0x047b2A7fc72862a0e3E772eb53b19d35929BEd46(Base/EVM, USDC or BUSD BEP20)