Draft
Conversation
ssannkkallpp
changed the title
| # Note: We do NOT use --with-ld-opt here because configure tests it with the | ||
| # native compiler, which fails for WASM flags. We'll patch the Makefile instead. | ||
| ./configure \ | ||
| --crossbuild=Linux::wasm32 \ |
Contributor
There was a problem hiding this comment.
What does this flag --crossbuild do
Contributor
Author
There was a problem hiding this comment.
This is to disable running test binaries during cross-compilation.
| --http-log-path=/var/log/nginx/access.log \ | ||
| --pid-path=/var/run/nginx.pid \ | ||
| --lock-path=/var/run/nginx.lock \ | ||
| --with-poll_module \ |
Contributor
There was a problem hiding this comment.
Is this module mandatory. Because all others seem to be disabled
Contributor
Author
There was a problem hiding this comment.
I figured we can't really test the execution without any event-driven functions, since we do support poll, it is included here to stay consistent with the static build, but open to any suggestions @vidyalakshmir
Contributor
There was a problem hiding this comment.
Okay then you can keep this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.