Open
Conversation
Member
Author
|
Can't run the cloud build check until merge of efficiency branch |
Makefile
Outdated
| NM_CAND=( \ | ||
| "$(LIND_WASM_ROOT)/clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04/bin/llvm-nm" \ | ||
| "$$(command -v llvm-nm || true)" \ | ||
| ) |
Contributor
There was a problem hiding this comment.
In case of clang, ar and ranlib, if the binaries with llvm are not found, they default to the generic ones.
The question is, if we need to do that. I think in our current build system, all these tools should default to llvm specific ones and if they are not present, the error should be reported.
@m-hemmings What do you think?
Member
Author
There was a problem hiding this comment.
That's fine with me, I can remove the fallbacks, that makes sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT CHANGED
preflightnow discoversNMfrom:$(LIND_WASM_ROOT)/clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04/bin/llvm-nmcommand -v llvm-nmpreflightnow fails ifllvm-nmis missing (ERROR: llvm-nm not found ...).build/.toolchain.envnow exportsNMalong withCLANG,AR,RANLIB.print-confignow printsNM.