ci/cd: Fix lind script and docker file #572
Open
+227
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
End-to-End Test ReportTest PreviewTest Report Deterministic TestsSummary
Test Results by Category
Non Deterministic TestsSummary
Test Results by Category
Fail TestsSummary
Test Results by Category
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
J7-7-7
previously approved these changes
Dec 15, 2025
Yaxuan-w
changed the title
Contributor
End-to-End Test ReportTest PreviewTest Report Deterministic TestsSummary
Test Results by Category
Non Deterministic TestsSummary
Test Results by Category
Fail TestsSummary
Test Results by Category
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
rennergade
reviewed
Dec 16, 2025
| # Policy: | ||
| # - If user explicitly specifies a profile, honor it strictly. | ||
| # - Otherwise: | ||
| # * Use the only available profile if exactly one exists. |
Contributor
There was a problem hiding this comment.
I think this isn't a great way to go about this since we can easily be confused that were using one while actually using the other. Id rather there be some sort of warning/error if there's a mismatch and we fix the environments properly.
m-hemmings
approved these changes
Dec 16, 2025
| ENV CLANG="/home/${USERNAME}/lind-wasm/${CLANG_PACKAGE}" | ||
|
|
||
| # --- Prebuild --- | ||
| ENV WASMTIME_PROFILE=debug |
Member
There was a problem hiding this comment.
Removing the implicit WASMTIME_PROFILE=debug avoids accidental debug/runtime mismatches. This should help ensure local dev matches CI behaviour more closely.
| # --- tool paths & quick checks (anchored to repo) --- | ||
| CLANG_BIN="clang" # must be on PATH | ||
| WASM_OPT_BIN="${REPO_ROOT}/tools/binaryen/bin/wasm-opt" | ||
| WASMTIME_PROFILE="${WASMTIME_PROFILE:-release}" |
Member
There was a problem hiding this comment.
Dropping implicit selection via WASMTIME_PROFILE makes execution more deterministic and avoids masked local issues. This sounds like it directly addresses the issue in issue #560
| WASMTIME_PROFILE="debug" | ||
| WASMTIME_BIN="${DBG_BIN}" | ||
| elif [[ ${rel_ok} -eq 1 && ${dbg_ok} -eq 1 ]]; then | ||
| echo "error: both release and debug wasmtime binaries exist:" >&2 |
Member
There was a problem hiding this comment.
This makes ambiguity explicit, which is good. One thing to think about. Do you plan to change any CI jobs or workflows to build both in the same workspace? If you ever do, you'll need to be mindful of this. Should be fine as it is now, though
| Options: | ||
| --wasmtime-profile=release|debug | ||
| Explicitly select which wasmtime build to use. |
Member
There was a problem hiding this comment.
This is clear in the help output. It might also be worth adding a short note to the developer docs/README that WASMTIME_PROFILE is no longer used for binary selection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the WASMTIME_PROFILE–related issue described in #560.
Previously, our development environment implicitly relied on
WASMTIME_PROFILEto decide which wasmtime binary to execute. In particular:WASMTIME_PROFILE=debug.As a result, both debug and release binaries could coexist, but
lind_runwould always execute the debug binary.This behavior masked issues locally and caused discrepancies between server-side development and CI, which runs in a clean environment.
This PR makes two related changes to eliminate the ambiguity:
In Dockerfile.dev:
In lind_run script:
--wasmtime-profile={release|debug}.In lind_compile script: