Suggested fix for the ltfs_ordered_copy single file special case issue. - #599
Merged
rangelmx merged 1 commit intoJul 29, 2026
Conversation
… above the special case, so len(args.keep_tree) no longer hits None
vandelvan
approved these changes
Jul 3, 2026
XV02
approved these changes
Jul 3, 2026
XV02
left a comment
XV02
left a comment
Contributor
There was a problem hiding this comment.
Great finding, thanks! LGTM
alexzc117
approved these changes
Jul 3, 2026
alexzc117
left a comment
alexzc117
left a comment
There was a problem hiding this comment.
Looks good for me! Thanks for your effort!
6 tasks
rangelmx
merged commit Jul 29, 2026
ba1695e
into
LinearTapeFileSystem:release/v2.4.9.0
7 checks passed
hugo-hur
added a commit
to hugo-hur/ltfs
that referenced
this pull request
Aug 6, 2026
Resolve the conflict in src/utils/ltfs_ordered_copy by re-applying the --move feature on top of the target's refactored copy path (the progress-based _run_copy/copyfileobj from LinearTapeFileSystem#586 and the single-file fix from LinearTapeFileSystem#599). The move now performs its post-copy source removal after _run_copy (so it also gets the progress bar), threads the move flag through CopyItem/walk_dir, and keeps the scoped directory pruning and the directory-metadata snapshot pass. LinearTapeFileSystem#599's keep_tree/single-file fix now comes from the target, so it is no longer carried on this branch. Verified on local disk: recursive move prunes the source and preserves directory mode/mtime; a non-recursive directory is left untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This pull request includes following changes or fixes.
args.keep_tree = ''just before the single file case to remove the python errorChecklist: