You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Split Atropos between initialization and main action.
Will be helpful in case when Atropos instance is created manually without Moirai.
Also is a starting point for refactoring Atropos's main_loop to the more flexible way of using.
Hi @pavlenko-volodymyr , thanks for the patch. Simoorg can have multiple Atropos each for a fate book that run under a single Morai currently.
Can you explain the use case for :
"Will be helpful in case when Atropos instance is created manually without Moirai."
Hi @MayureshGharat,
my use case needs ability to create Atropos instances without using Moirai and separate initialization from main usage.
In general this will be useful for those who plan to use their own implementation of Moirai, for e.g.
using pool of threads/processes/greenlets or use other implementation of REST API or else.
Hey @pavlenko-volodymyr one point I wanted to raise, was that this would definitely require unit test updates (atleast for atropos tests) could you include that in the pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split
Atroposbetween initialization and main action.Will be helpful in case when
Atroposinstance is created manually withoutMoirai.Also is a starting point for refactoring
Atropos'smain_loopto the more flexible way of using.Thanks