Open
Conversation
Changes to these files to fix the Heart Beat not working when client's wifi drops or it goes to to sleep causing the server to slow to a crawl. Heart Beat now works and client disconnects occur quickly with little disruption to other clients. Tested on ESP8266 with two WS servers and 5 clients. Clients can now reconnect after wifi drop. More debug statements added to trace the program flow.
Deleted - in wrong place
Modification to force new ping following timeout in WebSockets::handleHBTimeout
reverted to - 500 to force ping in HeartBeat time out
|
I think we are affected by this issue as well so getting this merged would be appreciated :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes solve the problems in:
#922 (comment)
Solves problems in HeartBeat.
Also readCb arguments change because the original had argument mismatch.
Changes to these files to fix the Heart Beat not working when client's wifi drops or it goes to to sleep causing the server to slow to a crawl. Heart Beat now works and client disconnects occur quickly with little disruption to other clients. Tested on ESP8266 with two WS servers and 5 clients. Clients can now reconnect after wifi drop. More debug statements added to trace the program flow.