Skip to content

[IMPROVE] 전체적으로 dynamic, lazy 적용 #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gs0428 merged 2 commits into from
Dec 11, 2025
Merged

[IMPROVE] 전체적으로 dynamic, lazy 적용 #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b124436
feat: dynamic + suspense 구조에서 dynamic 구조로 변경
gs0428 Dec 11, 2025
1dd1b87
refactor: suspense가 필요없는 dynamic은 lazy로 변경
gs0428 Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions apps/web/src/app/(with-side-bar)/topic/[id]/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
"use client";
import { lazy } from "react";

import dynamic from "next/dynamic";

const TopicStickerDetailModal = dynamic(
() => import("@/components/(with-side-bar)/topic/sticker/topic-sticker-detail-modal"),
{
ssr: false,
}
const TopicStickerDetailModal = lazy(
() => import("@/components/(with-side-bar)/topic/sticker/topic-sticker-detail-modal")
);

interface TopicBoardLayoutProps {
Expand Down
5 changes: 1 addition & 4 deletions apps/web/src/components/(with-side-bar)/layout/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
"use client";

import { Suspense } from "react";
import dynamic from "next/dynamic";
import Link from "next/link";
import { usePathname } from "next/navigation";
Expand Down Expand Up @@ -95,9 +94,7 @@ export default function Sidebar() {
<div className="text-muted-foreground mb-4 text-sm font-semibold uppercase tracking-wider">
나의 토픽
</div>
<Suspense fallback={<Spinner className="mx-auto" />}>
<RecentTopicList />
</Suspense>
<RecentTopicList />
</div>
</aside>

Expand Down
16 changes: 4 additions & 12 deletions apps/web/src/components/(with-side-bar)/topic/add-content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"use client";

import { Suspense, useRef, useState } from "react";
import { useRef, useState } from "react";
import dynamic from "next/dynamic";
import Link from "next/link";

Expand All @@ -20,15 +20,15 @@ const AddContentList = dynamic(() => import("./add-content-list"), {
),
});

interface AddContentListProps {
interface AddContentProps {
type: ContentTypeOptions;
id: string;
}

const MIN_WIDTH = 300;
const MAX_WIDTH = 600;

export default function AddContent({ type, id }: AddContentListProps) {
export default function AddContent({ type, id }: AddContentProps) {
const [contentPanelWidth, setContentPanelWidth] = useState(300); // Content Panel 기본 너비
const [searchQuery, setSearchQuery] = useState("");

Expand Down Expand Up @@ -90,15 +90,7 @@ export default function AddContent({ type, id }: AddContentListProps) {
<Link href={`/topic/${id}?type=${CONTENT_TYPE_OPTIONS.YOUTUBE}`}>유튜브</Link>
</Button>
</div>
<Suspense
fallback={
<div className="flex justify-center py-2">
<Spinner />
</div>
}
>
<AddContentList query={debouncedSearchQuery} id={id} type={type} />
</Suspense>
<AddContentList query={debouncedSearchQuery} id={id} type={type} />
</div>
<ResizeBar onMouseMove={onMouseMove} />
</>
Expand Down