CI: Fail on cppcheck.sh error#4119
Conversation
|
Fails as expected: |
|
Still failing but the CI doesn't build my code but probably the one it would get after merge. The failing line doesn't look like this in my branch: @BsAtHome That is what I was talking about in the other thread. Now the CI fails when there are cppcheck issues, so you dont't have to complain any more, the CI does it for you. There was a bug in cppcheck.sh This can only be merged after the issue in #4111 got fixed and merged, otherwise the CI on master will fail. Let's see if I can easily add a warn only list to shellcheck.sh. You can remove it as soon as all issues are fixed. |
|
And the shellcheck warn/error variant. This now generates CI errors except for the following files: This will help against creping in issues in other shell scripts and as soon as these files are fixed, you can remove the code again or also just remove the files from the list. |
712df2c to
18d2dd0
Compare
|
^Rebased back to master |
Fix issue in cppcheck.sh
So if one fails, you have still the result from the other

Fix issue in cppcheck.sh and make CI fail on cppcheck error
Additionally, make shellckeck.sh failing except for files that need yet to be fixed.