Lsb samples #5
Open
Lsb samples #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwichmann
reviewed
Nov 3, 2023
| and the "\fB/etc/foobar-release\fP" file contains: | ||
| and the "\fB/etc/os-release\fP" file contains: | ||
|
|
||
| NAME="SLES" |
There was a problem hiding this comment.
Not sure that we should be branding the example with a specific distribution - the original has been intentionally neutral on this.
| @@ -173,7 +173,7 @@ my ($help_text, $version_text) = map { | |||
| or die "$this_program: can't get `--$_' info from $ARGV[0]\n" | |||
| } qw(help), $opt_version_key; | |||
|
|
|||
| my $date = strftime "%B %Y", localtime; | |||
| my $date = strftime "%B %Y", gmtime($ENV{SOURCE_DATE_EPOCH} || time); | |||
There was a problem hiding this comment.
+1 - thanks for this addition!
| \fB"/etc/\fIdistrib\fB-release"\fR file. | ||
| override information which is parsed from the | ||
| \fB"/etc/os-release"\fR file. Since \fB"/etc/os-release"\fR is the new | ||
| standard, there is no need anymore to add any of the optional |
There was a problem hiding this comment.
It's a convention, yes - introduced by the systemd project and now in very wide usage. It's not correct to call it "standard", so in my opinion we might be looking for somewhat different wording here. This is just the manpage for the sample, so perhaps it doesn't matter too much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix from https://pagure.io/redhat-lsb