-
Notifications
You must be signed in to change notification settings - Fork 0
doc(MPS/ParentHamiltonian): align PGVWC boundary-word terminology #3277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -244,7 +244,7 @@ \section{The remaining boundary condition} | |
| block-diagonal boundary matrices whose block components again belong to the | ||
| blockwise periodic-boundary spaces. | ||
|
|
||
| The present formal boundary isolates the remaining source comparison in local | ||
| The present boundary isolates the remaining source comparison in cut-adapted | ||
| coordinates for boundary-crossing windows. Suppose | ||
| \begin{align} | ||
| \psi | ||
|
|
@@ -255,7 +255,7 @@ \section{The remaining boundary condition} | |
| For a cyclic interval beginning at \(i\) and crossing the boundary cut, put | ||
| \(a=i+L-N\). The word \(\beta\) records the part of the interval before the | ||
| chosen cut, while \(\rho\) records the outside word of length \(N-L\). These | ||
| are local coordinates for the proof, not names used in the source statement. | ||
| are the blocked words obtained by opening the source boundary-index comparison. | ||
| The conditional theorem assumes that, for every block \(j\) and every such | ||
| outside word \(\rho\), there is a matrix \(E_{j,i,\rho}\) such that for every | ||
| word \(\beta\) of length \(a\), | ||
|
|
@@ -283,7 +283,7 @@ \section{The remaining boundary condition} | |
| \leanid{MPSTensor.chainGroundSpace_toTensorFromBlocks_eq_iSup_and_iSupIndep_of_complementary_identities}.} | ||
|
|
||
| The live blueprint records that larger source statement with explicit citations | ||
| and separately marks the local cut coordinates used by the formalization, | ||
| and separates the cut-adapted coordinates from the paper's boundary indices, | ||
| without claiming that the source statement is proved.\footnote{Blueprint locations: | ||
| \path{def:parent_hamiltonian_ground_space_bnt} for the block-diagonal | ||
| periodic-boundary ground space, | ||
|
|
@@ -495,7 +495,7 @@ \section{Conclusion} | |
| and | ||
| \leanid{MPSTensor.chainGroundSpace_toTensorFromBlocks_eq_iSup_and_iSupIndep_of_trace_decomposition_bnt_c1_span}.} | ||
|
|
||
| The word-indexed \(C^j,D^j\) route is closer to the proof of | ||
| The cut-adapted \(C^j,D^j\) route is closer to the proof of | ||
| \cite[Theorem~12]{PerezGarcia2007MPSReps}. | ||
| The words \(\beta\) and \(\rho\) are local word coordinates introduced after | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Incomplete terminology pass: line 498 was changed to "The cut-adapted (C^j,D^j) route," but this line still calls the same objects (\beta,\rho) "local word coordinates." Within a single paragraph (lines 498–503), the two adjacent sentences now use inconsistent labels for the identical mathematical objects. The paper-gap policy ( Suggested fix: change "local word coordinates" to "cut-adapted coordinates" to match line 498. The rest of the sentence already carries the not-source-notation disclaimer and can remain unchanged. |
||
| opening and blocking the cyclic boundary comparison; they reindex the source | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incomplete terminology pass. This PR replaces the "formal word"/"word-indexed"/"local coordinate" phrasing for the PGVWC (C^j,D^j) boundary comparison with "cut-adapted coordinates" everywhere else in this note (lines 247, 258, 286) and in the Lean docstring and blueprint. But this line still calls (\beta,\rho) "local word coordinates," and the immediately preceding line (498) was just changed to "The cut-adapted (C^j,D^j) route." Using two different labels for the same (\beta,\rho) objects within one paragraph undercuts the internal consistency the PR is establishing, which the paper-gap policy (
docs/paper-gaps/policy.tex, "Shared commands"/coherence) asks notes to maintain.Suggested alignment:
The rest of the sentence — "they reindex the source end-site comparison (i_1,i_{m+1}) by blocked words, and are not additional hypotheses or terminology from the paper" — already carries the not-source-notation disclaimer and can stay.