audit: canonical form reduction proof completeness report#444
Closed
Copilot wants to merge 1 commit into
Closed
Conversation
Copilot
AI
changed the title
[WIP] Check full canonical form reduction proof from general MPS
audit: canonical form reduction proof completeness report
Apr 3, 2026
Owner
|
needs to be addressed |
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit of whether the full canonical form reduction from general MPS has been completely proved in both Lean and the blueprint.
Lean Code Status
TNLean/MPS/CanonicalForm/— ✅ 100% proved, 12/12 files, 0sorry. Full 7-stage pipeline (irreducible decomposition → PF normalization → periodicity removal → cyclic sector decomp → equal-norm handling → BNT assembly → normal canonical form) is complete.TNLean/MPS/BNT/— ✅ 100% proved, 5/5 files, 0sorry. Includescross_overlap_tendsto_zero, both permutation rigidity theorems,coeff_ratio_tendsto, Newton–Girard, and power-sum uniqueness.TNLean/MPS/Structure/— ✅ 100% proved, 4/4 files, 0sorry.TNLean/MPS/FundamentalTheorem/—PeriodicOverlap.lean— ❌ 8sorrystatements (Prop. 3.3 of arXiv:1708.00029):periodicSelfOverlap_tendstoperiodicOverlap_tendsto_zero_of_ne_periodsectorBlocked_isNormal_of_isPeriodicperiodicOverlap_tendsto_zero_of_no_sector_matchsectorMatch_propagationsectorTensor_proportional_of_blockedMatchperiodicOverlap_gaugeEquiv_of_sector_matchperiodicOverlapDichotomy← main theoremRoot cause: statements are still phrased for ambient tensors; the live API in
CyclicSectors.lean/Assembly.leanuses compressed sector tensors. The file header explicitly marks this as a skeleton pending API reformulation.Blueprint Annotation Status
\leanokcoveragech10_bnt.texch11_assembly.tex\notreadych08_canonical.tex\leanoktags are absentRecommended Actions
PeriodicOverlap.lean: re-state the 8 theorems against the compressed-sector API already inCyclicSectors.lean, then fill the proofs.ch08_canonical.tex: add\leanokto ~64 proved theorems; runleanblueprint checkdecls.ch11_assembly.tex: add\leanokto ~15 proved assembly theorems; keep\notreadyblock until (1) is resolved.Testing
rg -n "sorry" TNLean/MPS/CanonicalForm/ TNLean/MPS/BNT/ TNLean/MPS/Structure/→ 0 matches.rg -n "sorry" TNLean/MPS/FundamentalTheorem/PeriodicOverlap.lean→ 8 matches at lines 183, 207, 240, 280, 324, 374, 401, 456.\leanok/\lean{tags inblueprint/src/chapter/ch08_canonical.tex,ch10_bnt.tex,ch11_assembly.tex.Note
Low Risk
Low risk because there are no repository changes; review is limited to metadata/context only.
Overview
No repository files are modified in this PR (the provided diff is empty), so there is no functional or proof-state change to review.
Reviewed by Cursor Bugbot for commit ade4b5e. Bugbot is set up for automated code reviews on this repo. Configure here.