-
Notifications
You must be signed in to change notification settings - Fork 98
Updated Halo Wiki Info.lua #6911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Included Manual Squad Tables
hjpalpha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a fan
hjpalpha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code wise okay
still not a fan of enabeling it
imo PO should decide (and he is off until jan 5th)
Why aren't you a fan of enabling it? Is it because you think he should decide or some other reason? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm with @hjpalpha here
Just to be able to use it on a userspace page is not a good reason to enable legacy component
Manual squad is not a legacy component. |
and still it imo is preferable to just add the necessary transfers instead |
As the person said Manual squad is not a legacy component as CS, Rocket League, Dota and Apex still use it (along with others), if you could tell me the issue with Manual squad tables not even being an option on the halo wiki and then I could understand, we don't use Manual on Call of Duty or valorant, but having that option is extremely convenient, even then the esports wiki has Manual as an option, and halo has been out longer than that wiki |
Enabeling it allows Squad rows without the accompanying transfers even in main space. |
So by that logic it should be removed from every other wiki then no? I most definitely know that the CS contributors would be angry at the very least. We have also found a solution for that. |
|
IMO fine if you discussed this with other HALO contributors. |
I did and they are fine with it |
Well for older wikis which do not have all squad data available in transfers one can not enabled it untill all that data is available... Additionally some wikis actively opted against SquadAuto in general. Currently we generally enforce SquadAuto (i.e. disallow manual Squad tables) on wikis which use SquadAuto and have all necessary transfer data available. Especially all new wikis have it enforced. As said before imo PO should decide this |

Included Manual Squad Tables
Summary
I made it so manual Squad Tables are available on the Halo wiki as i would like to have squads on my user pages
How did you test this change?
This is the exact same code as on call of duty