Skip to content

Conversation

@PriZnJay
Copy link

@PriZnJay PriZnJay commented Dec 11, 2025

Included Manual Squad Tables

Summary

I made it so manual Squad Tables are available on the Halo wiki as i would like to have squads on my user pages

How did you test this change?

This is the exact same code as on call of duty

Included Manual Squad Tables
@PriZnJay PriZnJay changed the title Update Info.lua Update Halo Wiki Info.lua Dec 11, 2025
@PriZnJay PriZnJay changed the title Update Halo Wiki Info.lua Updated Halo Wiki Info.lua Dec 11, 2025
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a fan

@hjpalpha hjpalpha added the g: halo Halo label Dec 11, 2025
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code wise okay
still not a fan of enabeling it
imo PO should decide (and he is off until jan 5th)

@PriZnJay
Copy link
Author

code wise okay still not a fan of enabeling it imo PO should decide (and he is off until jan 5th)

Why aren't you a fan of enabling it? Is it because you think he should decide or some other reason?

Copy link
Collaborator

@ElectricalBoy ElectricalBoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm with @hjpalpha here
Just to be able to use it on a userspace page is not a good reason to enable legacy component

@mbergen
Copy link
Collaborator

mbergen commented Dec 11, 2025

I'm with @hjpalpha here Just to be able to use it on a userspace page is not a good reason to enable legacy component

Manual squad is not a legacy component.

@hjpalpha
Copy link
Collaborator

I'm with @hjpalpha here Just to be able to use it on a userspace page is not a good reason to enable legacy component

Manual squad is not a legacy component.

and still it imo is preferable to just add the necessary transfers instead

@PriZnJay
Copy link
Author

PriZnJay commented Dec 11, 2025

I'm with @hjpalpha here Just to be able to use it on a userspace page is not a good reason to enable legacy component

Manual squad is not a legacy component.

and still it imo is preferable to just add the necessary transfers instead

As the person said Manual squad is not a legacy component as CS, Rocket League, Dota and Apex still use it (along with others), if you could tell me the issue with Manual squad tables not even being an option on the halo wiki and then I could understand, we don't use Manual on Call of Duty or valorant, but having that option is extremely convenient, even then the esports wiki has Manual as an option, and halo has been out longer than that wiki

@hjpalpha
Copy link
Collaborator

I'm with @hjpalpha here Just to be able to use it on a userspace page is not a good reason to enable legacy component

Manual squad is not a legacy component.

and still it imo is preferable to just add the necessary transfers instead

As the person said Manual squad is not a legacy component as CS, Rocket League, Dota and Apex still use it (along with others), if you could tell me the issue with Manual squad tables not even being an option on the halo wiki and then I could understand, we don't use Manual on Call of Duty or valorant, but having that option is extremely convenient, even then the esports wiki has Manual as an option, and halo has been out longer than that wiki

Enabeling it allows Squad rows without the accompanying transfers even in main space.
Which would lead to transfers missing that should be added instead.

@PriZnJay
Copy link
Author

I'm with @hjpalpha here Just to be able to use it on a userspace page is not a good reason to enable legacy component

Manual squad is not a legacy component.

and still it imo is preferable to just add the necessary transfers instead

As the person said Manual squad is not a legacy component as CS, Rocket League, Dota and Apex still use it (along with others), if you could tell me the issue with Manual squad tables not even being an option on the halo wiki and then I could understand, we don't use Manual on Call of Duty or valorant, but having that option is extremely convenient, even then the esports wiki has Manual as an option, and halo has been out longer than that wiki

Enabeling it allows Squad rows without the accompanying transfers even in main space. Which would lead to transfers missing that should be added instead.

So by that logic it should be removed from every other wiki then no? I most definitely know that the CS contributors would be angry at the very least. We have also found a solution for that.
Screenshot 2025-12-11 132731

@mbergen
Copy link
Collaborator

mbergen commented Dec 11, 2025

IMO fine if you discussed this with other HALO contributors.

@PriZnJay
Copy link
Author

IMO fine if you discussed this with other HALO contributors.

I did and they are fine with it

@hjpalpha
Copy link
Collaborator

I'm with @hjpalpha here Just to be able to use it on a userspace page is not a good reason to enable legacy component

Manual squad is not a legacy component.

and still it imo is preferable to just add the necessary transfers instead

As the person said Manual squad is not a legacy component as CS, Rocket League, Dota and Apex still use it (along with others), if you could tell me the issue with Manual squad tables not even being an option on the halo wiki and then I could understand, we don't use Manual on Call of Duty or valorant, but having that option is extremely convenient, even then the esports wiki has Manual as an option, and halo has been out longer than that wiki

Enabeling it allows Squad rows without the accompanying transfers even in main space. Which would lead to transfers missing that should be added instead.

So by that logic it should be removed from every other wiki then no? I most definitely know that the CS contributors would be angry at the very least. We have also found a solution for that.

Well for older wikis which do not have all squad data available in transfers one can not enabled it untill all that data is available...

Additionally some wikis actively opted against SquadAuto in general.
(As you can see here CS has no usage of it in main space.)

Currently we generally enforce SquadAuto (i.e. disallow manual Squad tables) on wikis which use SquadAuto and have all necessary transfer data available. Especially all new wikis have it enforced.

As said before imo PO should decide this
(and PO as well as almost all of the other employees are not available until the week of jan 5th 2026)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants