-
Notifications
You must be signed in to change notification settings - Fork 98
fix: adjust infobox position with top page content #6913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adjusts the infobox positioning on desktop to minimize empty space created by the entity match ticker. The solution repositions the top content section beside the infobox using flexbox on mobile and a width calculation on desktop.
Key changes:
- Repositions infobox top content from above the infobox to beside it on desktop screens
- Implements responsive layout using flexbox ordering on mobile (≤600px) and width calculation on desktop (≥601px)
- Adds CSS class support to the Analytics widget to enable the new layout structure
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| stylesheets/commons/Infobox.scss | Adds container flexbox styling and topcontent width calculations for responsive positioning |
| lua/wikis/commons/Widget/Infobox/Core.lua | Wraps topContent in a div with CSS class and reorders it after the infobox wrapper in the DOM |
| lua/wikis/commons/Widget/Analytics.lua | Extends Analytics widget to support CSS classes for container styling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hjpalpha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should work
Summary
We want to push the infobox next to the top content section on desktop so the new entity match ticker creates minimum amount of empty space on the page.
The css (width calc) is a bit hacky solution for this, but works functionally. Just prone to break if the width or margin of infobox changes.
Also includes a small fix for not showing the
-for scores for upcoming matches on the vertical match cards.How did you test this change?
|dev=empton infobox that have entity match ticker and apply the css.screenrecording-2025-12-11_15-16-11.mp4