Skip to content

Conversation

@Eetwalt
Copy link
Collaborator

@Eetwalt Eetwalt commented Dec 11, 2025

Summary

We want to push the infobox next to the top content section on desktop so the new entity match ticker creates minimum amount of empty space on the page.

The css (width calc) is a bit hacky solution for this, but works functionally. Just prone to break if the width or margin of infobox changes.

Also includes a small fix for not showing the - for scores for upcoming matches on the vertical match cards.

How did you test this change?

|dev=empt on infobox that have entity match ticker and apply the css.

screenrecording-2025-12-11_15-16-11.mp4

Copilot AI review requested due to automatic review settings December 11, 2025 13:14
@Eetwalt Eetwalt added c: infobox stylesheets Changes to stylesheets labels Dec 11, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the infobox positioning on desktop to minimize empty space created by the entity match ticker. The solution repositions the top content section beside the infobox using flexbox on mobile and a width calculation on desktop.

Key changes:

  • Repositions infobox top content from above the infobox to beside it on desktop screens
  • Implements responsive layout using flexbox ordering on mobile (≤600px) and width calculation on desktop (≥601px)
  • Adds CSS class support to the Analytics widget to enable the new layout structure

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
stylesheets/commons/Infobox.scss Adds container flexbox styling and topcontent width calculations for responsive positioning
lua/wikis/commons/Widget/Infobox/Core.lua Wraps topContent in a div with CSS class and reorders it after the infobox wrapper in the DOM
lua/wikis/commons/Widget/Analytics.lua Extends Analytics widget to support CSS classes for container styling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should work

@Eetwalt Eetwalt requested a review from ElectricalBoy January 5, 2026 12:23
@Eetwalt Eetwalt merged commit 91cb628 into main Jan 7, 2026
6 checks passed
@Eetwalt Eetwalt deleted the entity-matchticker-position branch January 7, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: infobox stylesheets Changes to stylesheets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants