feat(match2): adjust breakpoints of player stats in match pages #6916
+83
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElectricalBoy
added
g: valorant
Collaborator
|
@FO-nTTaX do we consider that container querys have sufficient browser support? |
Collaborator
Author
it's baseline since Feb 2023 according to MDN Web Docs |
Member
yeah I think so, at least for size queries |
Collaborator
|
Whats the dev env for this? |
Collaborator
Author
Eetwalt
approved these changes
Jan 7, 2026
Collaborator
Eetwalt
left a comment
Eetwalt
left a comment
There was a problem hiding this comment.
Looks good, tested locally for all the dev pages. Still have some questions for the alignments of the player displays and stat displays when it goes to 2 rows but that can be tackled separately. This is an improvement so merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
@mediarules used for adjusting stats layout with@containerrulesHow did you test this change?
dev + browser dev tools