feat(standings): rounds tiebreaker types #6919
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjpalpha
reviewed
Dec 13, 2025
|
|
||
| ---@param opponent TiebreakerOpponent | ||
| ---@return {rounds: integer, w: integer, l: integer} | ||
| TiebreakerRoundUtil.getRounds = FnUtil.memoize(function (opponent) |
Collaborator
There was a problem hiding this comment.
wouldn't memoize cause issues if this is used with h2h or ml?
Collaborator
Author
There was a problem hiding this comment.
I think it will really depend on how h2h/ml modes are implemented
if we reconstruct TiebreakerOpponent to have a subset of TiebreakerOpponent.matches for each iteration of h2h/ml tiebreaking then memoizing wouldn't really cause issues
otherwise we might need to kick memoizing
hjpalpha
approved these changes
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the following tiebreakers:
How did you test this change?
valorant:User:ElectricalBoy/Sandbox2