-
Notifications
You must be signed in to change notification settings - Fork 98
feat(match2): make match2 behavior customizable for each project in lab #6925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
hjpalpha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems okayish
just make sure that we tell people that:
- there is no support at all for those kinds of modules (except for nuking them if they cause issues)
- if the project becomes an alpha wiki there is no guarantee we will port that version
- if the quality is up to standards (or close to it) we would use it as a basis most likely though
|
Do we expect these modules to be tracked via this repo? |
no |
That seems very much prone for errors (and thus conflicts) whenever base match modules are changed, potentially requiring adjustments of custom ones if we aren't aware of a bunch of them. |
somewhat intended; this pr's goal is giving an option for lab people to be on the bleeding edge if they decide to |
mbergen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as it's clear these aren't exactly supported, LGTM
Summary
Each project in the lab wiki has one root page and all content pages for a project are (grand)children of the root page.
This PR takes advantage of this structure and adds per-project entrypoints in lab match2, with the current lab match2 setup as a fallback.
How did you test this change?
preview with dev