Skip to content

Conversation

@ElectricalBoy
Copy link
Collaborator

@ElectricalBoy ElectricalBoy commented Dec 17, 2025

Summary

Each project in the lab wiki has one root page and all content pages for a project are (grand)children of the root page.
This PR takes advantage of this structure and adds per-project entrypoints in lab match2, with the current lab match2 setup as a fallback.

How did you test this change?

preview with dev

@ElectricalBoy ElectricalBoy added c: match2 lab Lab (Sandbox Wiki) labels Dec 17, 2025
@ElectricalBoy ElectricalBoy changed the title feat(match2): make match2 behavior customizable for each project feat(match2): make match2 behavior customizable for each project in lab Dec 17, 2025
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems okayish

just make sure that we tell people that:

  • there is no support at all for those kinds of modules (except for nuking them if they cause issues)
  • if the project becomes an alpha wiki there is no guarantee we will port that version
    • if the quality is up to standards (or close to it) we would use it as a basis most likely though

@mbergen
Copy link
Collaborator

mbergen commented Dec 17, 2025

Do we expect these modules to be tracked via this repo?

@ElectricalBoy
Copy link
Collaborator Author

Do we expect these modules to be tracked via this repo?

no

@ElectricalBoy ElectricalBoy marked this pull request as ready for review December 18, 2025 03:40
@mbergen
Copy link
Collaborator

mbergen commented Dec 18, 2025

Do we expect these modules to be tracked via this repo?

no

That seems very much prone for errors (and thus conflicts) whenever base match modules are changed, potentially requiring adjustments of custom ones if we aren't aware of a bunch of them.

@ElectricalBoy
Copy link
Collaborator Author

ElectricalBoy commented Dec 19, 2025

That seems very much prone for errors (and thus conflicts) whenever base match modules are changed, potentially requiring adjustments of custom ones if we aren't aware of a bunch of them.

somewhat intended; this pr's goal is giving an option for lab people to be on the bleeding edge if they decide to
hence we would be telling them to proceed at their own risk and they will be getting no support from us whatsoever as mentioned in hjp's review

Copy link
Collaborator

@mbergen mbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it's clear these aren't exactly supported, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: match2 lab Lab (Sandbox Wiki)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants