-
Notifications
You must be signed in to change notification settings - Fork 98
feat(TournamentsTicker): Add option to exclude selected events #6934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be a good idea to exclude tournaments with this new option enabled from Module:TournamentsSummaryTable too
the stored var is either bool or nil, no readBool needed
|
I dislike this feature, it's going to be abused and i don't see a good reason to add it in the first place. We have the ability to filter tickers by tier and tiertype, why isn't that sufficient?. As far as i can tell (Not much info during LP downtime), the discord conversation starter is a olympic-style tournament, in the end being a single tournament with multiple disciplines (cf. AoElympics on AoE wiki for something similar). |
¯_(ツ)_/¯ |
Summary
As per requests on discord add the option to exclude some tournaments from the Tournaments Ticker on main page.
This can be achieved by setting
|hide_on_tournaments_ticker=truein the infobox of the according event.start of discord conversation: https://discord.com/channels/93055209017729024/1209065403955806270/1453190691520909434
How did you test this change?
dev