Skip to content

refactor(infobox): clean up wildrift player infobox #6939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ElectricalBoy wants to merge 4 commits into
base: main
Choose a base branch
from
Open

refactor(infobox): clean up wildrift player infobox #6939

ElectricalBoy wants to merge 4 commits into from

Conversation

@ElectricalBoy
Copy link
Collaborator

@ElectricalBoy ElectricalBoy commented Dec 29, 2025

Summary

This PR:

  • replaces mw.getContentLanguage():ucfirst with String.upperCaseFirst
  • fixes return type for template entrypoint
  • adds missing class type annotations in wildrift player infobox

How did you test this change?

logically trivial

@ElectricalBoy ElectricalBoy added c: infobox g: wildrift League of Legends: Wild Rift labels Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hjpalpha hjpalpha hjpalpha approved these changes

@Eetwalt Eetwalt Awaiting requested review from Eetwalt

Assignees

No one assigned

Labels

c: infobox g: wildrift League of Legends: Wild Rift

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ElectricalBoy @hjpalpha