feat: rewrite AutomaticPointsTable #6941
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElectricalBoy
force-pushed
the
automatic-points-table-cleanup
branch
from
faa7c37 to
3fbf2f9
Compare
looks slightly better
hjpalpha
reviewed
Jan 1, 2026
| function AutomaticPointsTable:storeLPDB(opponents) | ||
| local date = DateExt.getContextualDateOrNow() | ||
| Array.forEach(opponents, function(opponent) | ||
| local teamName = Opponent.toName(opponent.opponent) |
Collaborator
There was a problem hiding this comment.
should rename, assuming we support this for non team opponents
Collaborator
Author
There was a problem hiding this comment.
actually it is limited to team opponents:
Lua-Modules/lua/wikis/commons/AutomaticPointsTable.lua
Lines 160 to 161 in 21e0e5d
- the old version supports teams only
- I didn't bother expanding to party opponents mainly to keep the old alias handling behavior
Collaborator
There was a problem hiding this comment.
ugh, so this module is entirely unusable for quite a few wikis...
Collaborator
Author
There was a problem hiding this comment.
well I think that it wouldn't be too hard to expand this to party opponents
we might need to rethink how to handle alias crap from scratch though
hjpalpha
approved these changes
Jan 2, 2026
Collaborator
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
seems cleaner, but still useless/unusable for lots of wikis
¯_(ツ)_/¯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Module:AutomaticPointsTableis an unused "legacy" component that has been left abandoned for years, while the "live" version used on wikis is a worse spaghetti that is not even on this repository. This PR rewrites the module with the current standards.How did you test this change?
https://liquipedia.net/valorant/User:ElectricalBoy/Sandbox3