feat(mainpage): automate 'in memory of' display in mainpages #6943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjpalpha
reviewed
Jan 2, 2026
Collaborator
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
fwiw when rolling this out we need to check if there is some usage of the current inmemory stuff so we do not double display banners
lua/wikis/commons/MainPageLayout.lua
Outdated
| conditions = tostring(ConditionTree(BooleanOperator.all):add{ | ||
| ConditionNode(ColumnName('deathdate'), Comparator.neq, DateExt.defaultDate), | ||
| ConditionNode(ColumnName('deathdate'), Comparator.ge, DateExt.toYmdInUtc( | ||
| DateExt.getCurrentTimestamp() - 1209600 --[[2 weeks]] |
Collaborator
There was a problem hiding this comment.
move the number into a const var
ElectricalBoy
force-pushed
the
mainpage-automate-in-memory-of
branch
from
4da64fb to
43e4b93
Compare
hjpalpha
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Depends on #6946
This PR automates use of #5569 in main pages.
How did you test this change?
https://liquipedia.net/leagueoflegends/User:ElectricalBoy/MainPage (dev uses 4 week offset for testing purposes instead of 2 weeks as specified in this PR)