Fix Flights.vue widget to work with the current aerodatabox API #1940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use .revisedTime.local and .scheduledTime.local instead of .actualTimeUTC which is no longer present in the API schema.
Display Departures if direction = 'departure' or 'both' Display Arrivals if direction = 'arrival' or 'both'
✅ Deploy Preview for dashy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Bugfix (widget)
Overview
The Flights widget in Dashy 3.1.1 didn't work because it tried to use a non-existing field
.movement.actualTimeUtcfrom Aerodatabox API endpoint. In the proposed PR,movement.scheduledTimeand.movement.revisedTimeare used instead, which fixes the Flights widget.Before:
After:
Additionally, the logic for Departures/Arrivals is fixed. Display Departures/Arrivals list in the widget per the
directionsetting.Issue Number
#1939
New Vars
None
Screenshot (if applicable)
No UI changes. Just fix the Flights widget, and make it work again.
Code Quality Checklist (Please complete)