LF-5219: Incorrect redirect to create farm page after changing password

[SayakaOno]

Description

Fix

Prevent unnecessary Route re-renders when form submissions update Redux state

Problem

When users submit the password reset form (in /password_reset), the Routes component would unexpectedly re-render and redirect them to /welcome, where they should see a modal and then be redirected to /farm_selection.

Root Cause

8bb5402 (Implementing offline navigation logging, v3.10.0 release on Feb 25, 2026)

The useOfflineActivityLogger hook was using useSelector(userFarmSelector), which subscribes to all changes in the userFarm Redux state. When the form submission updated user_id:

LiteFarm/packages/webapp/src/containers/PasswordResetAccount/index.jsx

Lines 19 to 22 in 5f2510f

	const onSubmit = (data) => {
	const { password } = data;
	dispatch(resetPassword({ reset_token, password, onPasswordResetSuccess, email }));
	};

LiteFarm/packages/webapp/src/containers/PasswordResetAccount/saga.js

Lines 28 to 49 in 5f2510f

	export function* resetPasswordSaga({
	payload: { reset_token, password, onPasswordResetSuccess, email },
	}) {
	try {
	const result = yield call(
	axios.put,
	resetPasswordUrl(),
	{ password },
	{
	headers: {
	Authorization: `Bearer ${reset_token}`,
	},
	},
	);
	const { id_token } = result.data;
	localStorage.setItem('id_token', id_token);
	const decoded = decodeToken(id_token);
	const { user_id } = decoded;
	yield put(loginSuccess({ user_id }));

LiteFarm/packages/webapp/src/containers/userFarmSlice.ts

Lines 104 to 106 in 5f2510f

	loginSuccess: (state, { payload: { user_id } }) => {
	state.user_id = user_id;
	},

it would:

1. Trigger <App /> to re-render (parent component)
2. Cause <Routes /> to re-render as a child
3. Re-evaluate routing logic unnecessarily and render <OnboardingFlow /> which doesn't have /password_reset

LiteFarm/packages/webapp/src/routes/index.jsx

Lines 343 to 344 in 5f2510f

	} else if (!hasSelectedFarm || !hasFinishedOnBoardingFlow) {
	return <OnboardingFlow {...userFarm} />;

4. Redirect the user unexpectedly

LiteFarm/packages/webapp/src/routes/Onboarding.jsx

Lines 198 to 200 in 5f2510f

	if ((!farm_id || !step_one) && !hasUserFarms) {
	return <Redirect to="/welcome" />;
	}

Solution

Made the offline activity logger's Redux subscription more granular by changing selector:
Use currentFarmIdSelector instead of userFarmSelector

• Only subscribes to farm_id changes, not all userFarm state
• Prevents re-renders from unrelated form submissions

I found this bug while testing the React Router upgrade and wanted to ship a fix as soon as possible.

Jira link: https://lite-farm.atlassian.net/browse/LF-5219

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• Passes test case
• UI components visually reviewed on desktop view
• UI components visually reviewed on mobile view
• Other (please explain)

Checklist:

• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• The precommit and linting ran successfully
• I have added or updated language tags for text that's part of the UI
• I have ordered translation keys alphabetically (optional: run pnpm i18n to help with this)
• I have added the GNU General Public License to all new files

[kathyavini]

Ooooh, I would never have come across that on my own or traced the route cause...!

and render <OnboardingFlow /> which doesn't have /password_reset

I'm not great on the logic of the routes files, but you don't think this is also worth fixing on its own, separate from the re-rendering? Am I understanding correctly the re-render exposed a little bit of faulty routing logic in that branch?

And also just checking my understanding that this would be something to watch for as we keep adding custom hooks to App.jsx (as has become a small pattern since the offline release!)... I don't think I was thinking at all about <Routes /> re-rendering when writing selectors in those hooks 🫤

[SayakaOno]

@kathyavini You’re right, the same thing happens when you go offline while the modal is shown.
The routing conditions seem quite complex, so I’ve been hesitant to update them 😅 I’ll create a bug ticket to make them more robust!
Ticket: https://lite-farm.atlassian.net/browse/LF-5256