Deduplicate API endpoints which specify a user in their route#1030
Merged
Toastbrot236 merged 9 commits intoFeb 20, 2026
Conversation
…he photo API endpoints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deduplicates such API endpoints by not having 2 whole endpoint methods per endpoint (one for users specified by username, one for users specified by UUID) by using the new
GetUserByIdAndTypedatabase method to allow multi-key lookups in a single endpoint method per endpoint.TODO: Although I've manually tested some of these endpoints, unit tests would be good for this. These will be many new tests though, but I've already finished a few of them.
EDIT: The tests I've just added cover most but not all modified endpoints, but I think these should be enough already.