Rework API level editing, refactor icon validation#1040
Merged
Conversation
Toastbrot236
commented
Mar 1, 2026
Contributor
- The normal and the admin API endpoint for editing a level now use separate request body classes/interfaces and DB methods
- These DB methods no longer use reflection. They now update levels similarly to how most other similar methods do it now (handle every wanted attribute separately). Closes Dont use reflection to update level details #579
- All API endpoints which need to validate icons now use one helper method for this. Removes duplicate code and inconsistent validation processes this way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.