Better organize/deduplicate role-specific config options, separate timed level limit for trusted users#1065
Merged
Conversation
… limit for trusted users
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves certain
GameServerConfigoptions, like read-only and blocked asset flags, to child objects inside the root config JSON. This way we can also easily add further role-specific options if we ever want to introduce more (trusted) roles (see #1061), only have to add one more attribute to the root config class per role, instead of another set of duplicate attributes.Also makes timed level limits role specific, making normal and trusted users have separate level limits like that, closing #754.
Might need a little more testing before merging.