Completed and reference splits #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 17, 2020 15:47
Moved column-type enumeration to avoid breaking auto-generated code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new ColumnType options. Both are intended to address Issue 1424.
The first is "completed splits", which shows the time of completed splits but is otherwise blank.
The second is "reference splits", which always shows the reference time (e.g., personal best, etc.).
This screenshot shows example usage with three columns, of type "Reference Splits", "Delta", and "Completed Splits".
I've also added a few lines in the ColumnSettings constructor, which makes it easier to keep the ColumnType options in sync with displayed values.