Add support for detecting press and release events in livesplit-hotkey via new API register_specific
#878
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #633
Changes
Adds
register_specific, which allows the developer to provide a callback that takes a single boolean argument that dictates whether the event was a press or release.Disclaimer
I understand that the issue this is linked to was labelled "needs further discussion" due to it being a bit out of scope of the needs of livesplit, which is totally fair. I originally implemented this for my own use, but decided it was worth PR'ing just in case it would be considered.
The entire implementation is feature-gated, partly due to this concern:
which is valid! The feature gating means it should not effect the existing hotkey registration/performance in any way, so long as the feature is not explicitly enabled.
Other notes
register_specificis obvious enough in expressing what it actually does/allows hahaTest Program