Skip to content

Added Package Configuration + Github Action Workflow for PRs#103

Open
97saundersj wants to merge 34 commits intoLivingFray:masterfrom
97saundersj:GithubActions
Open

Added Package Configuration + Github Action Workflow for PRs#103
97saundersj wants to merge 34 commits intoLivingFray:masterfrom
97saundersj:GithubActions

Conversation

@97saundersj
Copy link
Contributor

@97saundersj 97saundersj commented Dec 22, 2024

Package Configuration

To simplify the process of supplying a zip file for testing for new changes I have created a new Package Configuration.
This Configuration will first run manifest.py to update the controller bindings, then build the d3d9.dll file, and finally run makerelease.bat to package everything together in the 'HaloCEVR.zip' file.
To do this simply change the Configuration in Visual Studio to Package and then build.

Package Pull Request Action

I have also created a new Github Action Workflow for automatically Running the Package Configuration for Pull Requests into Master. This means that when a new change is pushed to the Pull Request the changes will be automatically built and packaged in a 'HaloCEVR.zip' file. This will let contributors know if the changes will build correctly and will provide a ZIP file for any reviewers to test the latest changes.
I'm not sure what the Repositories "Approval for running fork pull request workflows from contributors" is set to but I believe that contributors will first need approval before the workflow will run for their PRs.

To view an example of this workflow see the actions on my forked repository here: https://github.com/97saundersj/HaloCEVR/actions

I would also be happy to create more workflows in the future e.g. for automatically generating a zip file when the Master branch is updated, or to make the bindings get generated with the other Configurations to make sure that they are always up to date.

As always any feedback is appreciated.

@97saundersj 97saundersj marked this pull request as ready for review December 22, 2024 21:12
@97saundersj 97saundersj marked this pull request as draft December 22, 2024 21:16
@97saundersj 97saundersj marked this pull request as ready for review December 30, 2024 22:53
@LivingFray
Copy link
Owner

This looks cool, I never got around to learning how to use github actions myself.
However when I downloaded the artifacts from the example you linked it didn't have any dll files in it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants