Skip to content

fix(amf): attempt to use level 5.1/5.2 for hevc #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mariotaku
Copy link
Contributor

@mariotaku mariotaku commented May 19, 2025

Description

AMF Encodes HEVC in L6.2 by default. Some clients can't properly handle level higher than 5.2 (e.g. webOS: mariotaku/moonlight-tv#355)

This PR tries to use a lower level when possible, determined by resolution/frame rate automatically according to specs, which improves compatibility.

Screenshot

Not applicable.

Issues Fixed or Closed

Resolve mariotaku/moonlight-tv#355

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@mariotaku mariotaku marked this pull request as draft May 19, 2025 01:28
@mariotaku mariotaku changed the title Attempt to Use L5.1/5.2 for AMF HEVC Encoder fix(amf): attempt to use level 5.1/5.2 for hevc May 19, 2025
@mariotaku mariotaku force-pushed the feature/amf-hevc-lower-codec-level branch from 6c9a2e4 to 27b2f50 Compare May 19, 2025 07:14
@mariotaku mariotaku force-pushed the feature/amf-hevc-lower-codec-level branch from 27b2f50 to a0ff194 Compare May 19, 2025 07:48
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5 New issues
5 New Code Smells (required ≤ 0)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Black Screen with AMD Encoded H265 Stream
1 participant