Skip to content

refactor: sonar fixes - #143

Merged
ReenigneArcher merged 1 commit into
masterfrom
refactor/sonar-fixes
May 30, 2026
Merged

refactor: sonar fixes#143
ReenigneArcher merged 1 commit into
masterfrom
refactor/sonar-fixes

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Sonar fixes.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented May 30, 2026

Copy link
Copy Markdown

Bundle Report

Changes will increase total bundle size by 36 bytes (0.41%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
shared-web-array-push 8.81kB 36 bytes (0.41%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: shared-web-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
gamepad-helper.js 36 bytes 8.81kB 0.41%

Files in gamepad-helper.js:

  • ./src/js/gamepad-helper.js → Total Size: 19.75kB

@codecov

codecov Bot commented May 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a82a825) to head (593a3d0).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #143   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           74        75    +1     
  Branches        25        24    -1     
=========================================
+ Hits            74        75    +1     
Files with missing lines Coverage Δ
src/js/gamepad-helper.js 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a82a825...593a3d0. Read the comment docs.

@ReenigneArcher
ReenigneArcher merged commit 36d1303 into master May 30, 2026
16 checks passed
@ReenigneArcher
ReenigneArcher deleted the refactor/sonar-fixes branch May 30, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant