Skip to content

fix: add vendor/product gamepad ID matching - #183

Merged
ReenigneArcher merged 1 commit into
masterfrom
fix/gamepad-identities
Aug 15, 2026
Merged

fix: add vendor/product gamepad ID matching#183
ReenigneArcher merged 1 commit into
masterfrom
fix/gamepad-identities

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Add a fallback lookup that normalizes Gamepad API IDs into vendor/product pairs so controllers can still be identified when browsers expose different product names. This covers Chromium and Firefox ID formats, adds an explicit VID/PID mapping for the generic controller, and expands tests for the new lookup paths while preserving existing XInput label behavior.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Bundle Report

Changes will increase total bundle size by 7.63kB (108.14%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
gamepad-helper-array-push 7.63kB 7.63kB (100%) ⬆️⚠️

@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (81447b5) to head (bc5b8a5).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #183   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           75        96   +21     
  Branches        24        30    +6     
=========================================
+ Hits            75        96   +21     
Files with missing lines Coverage Δ
src/js/gamepad-helper.js 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81447b5...bc5b8a5. Read the comment docs.

Add a fallback lookup that normalizes Gamepad API IDs into vendor/product pairs so controllers can still be identified when browsers expose different product names. This covers Chromium and Firefox ID formats, adds an explicit VID/PID mapping for the generic controller, and expands tests for the new lookup paths while preserving existing XInput label behavior.
@ReenigneArcher
ReenigneArcher force-pushed the fix/gamepad-identities branch from c7b0e13 to bc5b8a5 Compare August 15, 2026 15:23
@sonarqubecloud

Copy link
Copy Markdown

@ReenigneArcher
ReenigneArcher merged commit 9316d76 into master Aug 15, 2026
15 checks passed
@ReenigneArcher
ReenigneArcher deleted the fix/gamepad-identities branch August 15, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant