fix: add vendor/product gamepad ID matching - #183
Merged
Conversation
Bundle ReportChanges will increase total bundle size by 7.63kB (108.14%) ⬆️
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #183 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 75 96 +21
Branches 24 30 +6
=========================================
+ Hits 75 96 +21
Continue to review full report in Codecov by Harness.
|
Add a fallback lookup that normalizes Gamepad API IDs into vendor/product pairs so controllers can still be identified when browsers expose different product names. This covers Chromium and Firefox ID formats, adds an explicit VID/PID mapping for the generic controller, and expands tests for the new lookup paths while preserving existing XInput label behavior.
ReenigneArcher
force-pushed
the
fix/gamepad-identities
branch
from
August 15, 2026 15:23
c7b0e13 to
bc5b8a5
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Add a fallback lookup that normalizes Gamepad API IDs into vendor/product pairs so controllers can still be identified when browsers expose different product names. This covers Chromium and Firefox ID formats, adds an explicit VID/PID mapping for the generic controller, and expands tests for the new lookup paths while preserving existing XInput label behavior.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.