This repository was archived by the owner on Feb 10, 2026. It is now read-only.
Add SOCKS4 and HTTP CONNECT proxy support#405
Closed
ooopus wants to merge 2 commits intoLonami:masterfrom
Closed
Conversation
49246cb to
90443ba
Compare
Lonami
suggested changes
Feb 9, 2026
Owner
Lonami
left a comment
There was a problem hiding this comment.
Please submit separate PRs for different features. I'm OK with merging the addition of requires_join_request, but manually implementing SOCKS4 is not something I'm comfortable with (I do not want to maintain or debug that part of the code). I would rather add an extra optional dependency to take care of it.
Owner
|
Closing in favor of #408. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.