-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update apache.yml #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe update adds an Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
Ingress/apache.yml (2)
5-6: Consider adopting the full Kubernetes recommended label setAdding the
app: apachelabel is 👍 and keeps selectors consistent, but you might get extra mileage (better tooling support & observability) by embracing the conventionalapp.kubernetes.io/*keys.
Example:labels: - app: apache + app: apache + app.kubernetes.io/name: apache + app.kubernetes.io/component: web + app.kubernetes.io/managed-by: kubectlThis is optional, yet it future-proofs the manifest and aligns with K8s best-practice docs.
27-28: Mirror the enhanced label set on the Service for symmetryIf you decide to enrich the Deployment labels as suggested above, mirror the same keys on the Service to keep selectors/filters predictable across resources.
Dasmat13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The app: apache label helps organize and select Kubernetes resources effectively. Clean and minimal change — approved.
Summary by CodeRabbit