feat!: rewrite #4
Conversation
Samathingamajig
left a comment
Samathingamajig
left a comment
There was a problem hiding this comment.
a few things that jumped out to me
|
I've updated the PR title to indicate that it contains breaking changes. |
|
@EthanL06 For such a big PR such as thsi one where you're rewriting most if not all of the codebase, please update your original comment to include the tech stack used and any other major changes you've made please. |
doprz
left a comment
doprz
left a comment
There was a problem hiding this comment.
Please refer to my previous comments in addition to updating README.md.
I will be performing a more detailed PR review soon.
…ound script with tabs permission
|
|
||
| const addVTTListener = () => { | ||
| if (!isListenerActive) { | ||
| browser.webRequest.onBeforeRequest.addListener(requestListener, { urls: ['*://*.la.utexas.edu/*'] }, [ |
There was a problem hiding this comment.
Not a big fan of hardcoding this in. Let's extract this into a const object.
| manifest: { | ||
| permissions: ['webRequest', 'tabs'], | ||
| name: 'UT Lectures Plus', | ||
| description: | ||
| 'This plugin adds a transcript box (with search) to all LectureOnline and TowerLA lectures from UT Austin! Studying has never been easier.', |
There was a problem hiding this comment.
Would be a good idea to import this from package.json
|
@EthanL06 , just left some nit comments but we can fix the nit things now or in the future as they don't affect functionality, up to you. Overall great job with this rewrite! @Samathingamajig this PR LGTM once the comments/feedback have been addressed so that we can start creating issues and PRs that depend on this PR. |
|
Todo:
|
…anscription component
…anscription component
Entire rewrite of UTLP codebase.
Tech stack:
Major changes:
All of the main code is under
src/entrypoints.src/entrypoints/main.content: contains everything related to the sidebar.src/entrypoints/injected.contentcontains everything related to the injected CSS on the website.src/entrypoints/popupcontains everything related to popupsrc/entrypoints/background.tsis the background script