Skip to content
This repository was archived by the owner on Mar 8, 2026. It is now read-only.

feat/favorites#22

Open
Astrol99 wants to merge 81 commits into
mainfrom
feat/favorites
Open

feat/favorites#22
Astrol99 wants to merge 81 commits into
mainfrom
feat/favorites

Conversation

@Astrol99

Copy link
Copy Markdown
Collaborator

resolves #15
image
image

@Astrol99 Astrol99 requested review from Copilot and rithvikch June 2, 2025 18:44
rithvikch
rithvikch previously approved these changes Jun 2, 2025

@rithvikch rithvikch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rithvikch

Copy link
Copy Markdown
Collaborator

lgtm

@rithvikch rithvikch closed this Jun 2, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements new features and improvements for the "feat/favorites" initiative by introducing several new UI components, updating routing paths, and upgrading dependencies and configurations for the Longhorn Studies application. Key changes include:

  • Enhancements and additions to core components such as TagSelector, SpotIcon, SpotCard, and ImageUploader.
  • Updates to routing in authentication and protected areas including sign up, login, and tab navigation.
  • Various dependency upgrades and configuration changes in package.json, babel.config.js, and app.json.

Reviewed Changes

Copilot reviewed 37 out of 37 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
longhorn-studies/package.json Added new scripts and upgraded dependency versions.
longhorn-studies/components/TagSelector.tsx New component for tag selection with debounced search and tag management.
longhorn-studies/components/SpotIcon.tsx New component to display spot images with a loading indicator and gradient overlay.
longhorn-studies/components/SpotCard.tsx New component for rendering spot cards with favorite toggle functionality.
longhorn-studies/components/ImageUploader.tsx New component for multi-image upload with drag-and-drop reordering.
longhorn-studies/components/Container.tsx Updated to wrap SafeAreaView inside an extra View for improved layout.
longhorn-studies/components/Button.tsx Updated button styles and spacing.
longhorn-studies/babel.config.js Modified presets to include unstable_transformImportMeta option.
Various app/(app)/* files Updated routing paths and UI elements such as title and icon color adjustments.
longhorn-studies/app/(app)/(protected)/create-spot.tsx Added create spot form with image processing, tag selection, and map location setup.
longhorn-studies/app/(app)/(protected)/(tabs)/* Improved tab layout, map integration, and explored spot/favorites listings.
longhorn-studies/app.json and .vscode/settings.json Configuration adjustments for project name, owner, and formatter settings.
Comments suppressed due to low confidence (1)

longhorn-studies/app/(app)/(protected)/create-spot.tsx:104

  • [nitpick] The magic numbers used for checking the longitude range could be extracted into well-named constants or documented for clarity.
if (newImages[0].exif.GPSLongitudeRef === 'W' || (longitude > 100 && longitude < 180) // North America western regions) {

Comment thread longhorn-studies/components/SpotIcon.tsx
Comment thread longhorn-studies/components/SpotCard.tsx
Comment thread longhorn-studies/app/(app)/(protected)/create-spot.tsx
@Astrol99 Astrol99 reopened this Jun 2, 2025
@Astrol99 Astrol99 dismissed rithvikch’s stale review June 2, 2025 19:49

The merge-base changed after approval.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spot Favorites

3 participants