[VCU] stompp fix#312
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the default brake system encoder (BSE) pressure thresholds and adds a TODO comment in TorqueMap.c noting that torque_derated is currently unused. The reviewer highlighted a significant safety and reliability concern: because torque_derated is unused, battery cell voltage and temperature derating are non-functional, meaning the VCU will not protect the battery cells from over-discharge or thermal stress. It is recommended to update subsequent torque processing stages to consume torque_derated instead of torque_lookup_output.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| out->derate_factor_cell_voltage = compute_low_cell_voltage_derate(out->open_circuit_cell_voltage, params); | ||
| out->derate_factor_cell_temp = 1.0f; // TODO: cell temp derate | ||
|
|
||
| // TODO - torque_derated isn't even used, whoops. So derates don't do anything |
There was a problem hiding this comment.
Leaving a TODO acknowledging that torque_derated is unused means that battery cell voltage and temperature derating are completely non-functional. This is a significant safety and reliability concern, as the VCU will not protect the battery cells from over-discharge or thermal stress under high load. Please ensure that the subsequent torque processing stages (such as power limiting or traction control) consume torque_derated instead of torque_lookup_output to make the derating logic effective.
1 participant
No description provided.