Skip to content

Conversation

@rly
Copy link
Collaborator

@rly rly commented Sep 22, 2025

Fix #19

@samuelbray32 Is this how a rectangular region should be defined? For the usage of spatial_filter_region_node_coordinates_in_pixels, are the coordinates of the last node supposed to equal the coordinates of the first node (so there should be num_nodes+1 coordinates in the list)? Or is it assumed that the polygon closes by connecting the last node to the first node, like I set up in the test here?

@rly rly requested a review from samuelbray32 September 22, 2025 20:40
@samuelbray32
Copy link
Collaborator

Thanks for the catch. That's right, we assume closure between the last and first node without explicitly repeating the first node

@rly rly merged commit 6b566b8 into master Sep 22, 2025
29 checks passed
@rly rly deleted the fix_spatial_filter_region_test branch September 22, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spatial_filter_region_node_coordinates_in_pixels usage in test is missing a dimension

3 participants