-
Notifications
You must be signed in to change notification settings - Fork 52
Maintenance tool revision #1226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
edeno
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment about folder name.
One thing that might be useful is for the script to warn us (by email perhaps?) if it fails to run. These scripts often are set and forget but if they stop working we want to know.
| `dj_local_conf.json` and filling in the necessary information. | ||
| 3. Set up a cron job to run `run_jobs.sh` at the desired interval by running | ||
| `crontab -e` and adding the script. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to call this franklab scripts or something more general that other labs can repurpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to rename, maybe maintenance_scripts? Is it worth moving these .py files into the package itself and then maybe putting the .sh in the docs, to cut down on the root level folders?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That works for me.
|
Hm also not sure why the tests are suddenly failing. |
It looks like this is happening when |
Description
This PR makes a series of changes to update our maintenance tools, revising the cron job process:
nightly_cleanup->cleanup: no need to specify inaccurate frequencycleanup.pyto clean schema externals and delete temp files more than 1 week old.run_jobs.shscript to be set as cron job and corresponding READMEalter_tablesscript to run on all tables.SHARED_MODULESfor readability and remove unused prefixIntervalList.insertcalls to never skip duplicatesChecklist:
CITATION.cffaltersnippet for release notes.CHANGELOG.mdwith PR number and description.