Skip to content

Conversation

@edeno
Copy link
Collaborator

@edeno edeno commented Mar 4, 2025

Description

The cli module is only used by a small subset of users and unmaintained. I propose we remove it.

Checklist:

  • This PR should be accompanied by a release: (yes/no/unsure)
  • If release, I have updated the CITATION.cff
  • This PR makes edits to table definitions: (yes/no)
  • If table edits, I have included an alter snippet for release notes.
  • If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • I have added/edited docs/notebooks to reflect the changes

@edeno edeno requested a review from CBroz1 March 4, 2025 16:46
Copy link
Member

@CBroz1 CBroz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I would remove this line
  2. Is there any argument for taking the time to declare a new spyglass_cli installable package? Or do we think it's the case that no one uses this?

@edeno
Copy link
Collaborator Author

edeno commented Mar 7, 2025

I think @magland might possibly be the only person using it. It would be simple enough to make it a separate package.

@edeno edeno requested a review from CBroz1 March 7, 2025 17:32
@edeno edeno merged commit 770f4cf into master Mar 7, 2025
19 of 20 checks passed
@edeno edeno deleted the remove-cli branch March 7, 2025 17:34
@magland
Copy link
Contributor

magland commented Mar 7, 2025

I think @magland might possibly be the only person using it. It would be simple enough to make it a separate package.

not using it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants