-
Notifications
You must be signed in to change notification settings - Fork 52
SpikeSortingRecording v0: generator, short-transation make #1338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Previously marked as draft pending release of DataJoint 0.14.5 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1338 +/- ##
==========================================
+ Coverage 69.19% 69.70% +0.50%
==========================================
Files 103 103
Lines 12305 12535 +230
==========================================
+ Hits 8515 8738 +223
- Misses 3790 3797 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements the generator-based make approach for the SpikeSortingRecording table to support short-transaction processing. This is the first step in addressing issue #1332 by decomposing the traditional make method into three separate phases: make_fetch, make_compute, and make_insert.
- Refactored
SpikeSortingRecording.make()into generator-based methods for better transaction management - Updated datajoint dependency to version 0.14.5 to support the new generator approach
- Added changelog entry documenting the implementation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/spyglass/spikesorting/v0/spikesorting_recording.py | Refactored make method into make_fetch, make_compute, and make_insert phases |
| pyproject.toml | Updated datajoint minimum version requirement from 0.14.4 to 0.14.5 |
| CHANGELOG.md | Added entry documenting the short-transaction make implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Just some minor docstring consistency comments.
Description
This PR is the first step to addressing #1332, making use of the generator
makeapproachChecklist:
CITATION.cffaltersnippet for release notes.CHANGELOG.mdwith PR number and description.