Skip to content

Conversation

@CBroz1
Copy link
Member

@CBroz1 CBroz1 commented Jun 20, 2025

Description

This PR is the first step to addressing #1332, making use of the generator make approach

Checklist:

  • No. This PR should be accompanied by a release: (yes/no/unsure)
  • N/a If release, I have updated the CITATION.cff
  • No. This PR makes edits to table definitions: (yes/no)
  • N/a. If table edits, I have included an alter snippet for release notes.
  • N/a. If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • N/a. I have added/edited docs/notebooks to reflect the changes

@CBroz1 CBroz1 marked this pull request as ready for review July 29, 2025 16:50
@CBroz1
Copy link
Member Author

CBroz1 commented Jul 29, 2025

Previously marked as draft pending release of DataJoint 0.14.5

@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.70%. Comparing base (881877b) to head (cfb2642).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1338      +/-   ##
==========================================
+ Coverage   69.19%   69.70%   +0.50%     
==========================================
  Files         103      103              
  Lines       12305    12535     +230     
==========================================
+ Hits         8515     8738     +223     
- Misses       3790     3797       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@edeno edeno requested a review from Copilot August 6, 2025 17:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the generator-based make approach for the SpikeSortingRecording table to support short-transaction processing. This is the first step in addressing issue #1332 by decomposing the traditional make method into three separate phases: make_fetch, make_compute, and make_insert.

  • Refactored SpikeSortingRecording.make() into generator-based methods for better transaction management
  • Updated datajoint dependency to version 0.14.5 to support the new generator approach
  • Added changelog entry documenting the implementation

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/spyglass/spikesorting/v0/spikesorting_recording.py Refactored make method into make_fetch, make_compute, and make_insert phases
pyproject.toml Updated datajoint minimum version requirement from 0.14.4 to 0.14.5
CHANGELOG.md Added entry documenting the short-transaction make implementation

@edeno edeno added this to the 0.5.6 milestone Aug 6, 2025
@CBroz1 CBroz1 requested a review from edeno August 7, 2025 20:57
@edeno edeno changed the title SpikeSortingRecording: generator, short-transation make SpikeSortingRecording v0: generator, short-transation make Aug 8, 2025
Copy link
Collaborator

@edeno edeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Just some minor docstring consistency comments.

@CBroz1 CBroz1 requested a review from edeno August 11, 2025 14:48
@edeno edeno merged commit 1446caa into LorenFrankLab:master Aug 11, 2025
17 checks passed
@CBroz1 CBroz1 deleted the gm1 branch November 6, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants