Skip to content

Make sure parent directory exists in decoding #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 11, 2025
Merged

Make sure parent directory exists in decoding #1362

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0dc4bd4
Make sure parent directory exists
edeno Aug 7, 2025
e97e487
Create directory first
edeno Aug 8, 2025
2e39bb2
Fix directory
edeno Aug 8, 2025
a2a6bac
Update CHANGELOG.md
edeno Aug 8, 2025
659a81e
Merge branch 'master' into fix-decoding-path
edeno Aug 11, 2025
f2fd46c
Fix changelog
edeno Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ When altering tables, import all foreign key references.
- Thing
-->

### Decoding

- Ensure results directory is created if it doesn't exist #1362

## [0.5.5] (Aug 6, 2025)

### Infrastructure
Expand Down
10 changes: 7 additions & 3 deletions src/spyglass/decoding/v1/clusterless.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,15 +279,19 @@ def make(self, key):

nwb_file_name = key["nwb_file_name"].replace("_.nwb", "")

# Make sure the results directory exists
results_dir = Path(config["SPYGLASS_ANALYSIS_DIR"]) / nwb_file_name
results_dir.mkdir(parents=True, exist_ok=True)

# Generate a unique path for the results file
path_exists = True
while path_exists:
results_path = (
Path(config["SPYGLASS_ANALYSIS_DIR"])
/ nwb_file_name
/ f"{nwb_file_name}_{str(uuid.uuid4())}.nc"
results_dir / f"{nwb_file_name}_{str(uuid.uuid4())}.nc"
)
# if the results_path already exists, try a different uuid
path_exists = results_path.exists()

classifier.save_results(
results,
results_path,
Expand Down
10 changes: 7 additions & 3 deletions src/spyglass/decoding/v1/sorted_spikes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,15 +236,19 @@ def make(self, key):

nwb_file_name = key["nwb_file_name"].replace("_.nwb", "")

# Make sure the results directory exists
results_dir = Path(config["SPYGLASS_ANALYSIS_DIR"]) / nwb_file_name
results_dir.mkdir(parents=True, exist_ok=True)

# Generate a unique path for the results file
path_exists = True
while path_exists:
results_path = (
Path(config["SPYGLASS_ANALYSIS_DIR"])
/ nwb_file_name
/ f"{nwb_file_name}_{str(uuid.uuid4())}.nc"
results_dir / f"{nwb_file_name}_{str(uuid.uuid4())}.nc"
)
# if the results_path already exists, try a different uuid
path_exists = results_path.exists()

classifier.save_results(
results,
results_path,
Expand Down
Loading