Skip to content

Migrate from upstream_hash to tri-part make #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 47 commits into
base: master
Choose a base branch
from

Deprecate warning for no_transaction make

e476f51
Select commit
Loading
Failed to load commit list.
Open

Migrate from upstream_hash to tri-part make #1422

Deprecate warning for no_transaction make
e476f51
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 19, 2025 in 0s

71.09% (target 68.00%)

View this Pull Request on Codecov

71.09% (target 68.00%)

Details

Codecov Report

❌ Patch coverage is 63.68421% with 69 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.09%. Comparing base (b17c225) to head (e476f51).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/spyglass/behavior/v1/moseq.py 0.00% 23 Missing ⚠️
src/spyglass/position/v1/position_dlc_training.py 29.16% 17 Missing ⚠️
src/spyglass/common/common_ephys.py 15.78% 16 Missing ⚠️
.../spyglass/spikesorting/v0/spikesorting_curation.py 93.15% 5 Missing ⚠️
src/spyglass/spikesorting/v1/figurl_curation.py 37.50% 5 Missing ⚠️
src/spyglass/common/common_interval.py 50.00% 1 Missing ⚠️
...spyglass/spikesorting/v0/spikesorting_recording.py 91.66% 1 Missing ⚠️
...c/spyglass/spikesorting/v0/spikesorting_sorting.py 94.11% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1422      +/-   ##
==========================================
- Coverage   71.35%   71.09%   -0.26%     
==========================================
  Files         114      114              
  Lines       13282    13370      +88     
==========================================
+ Hits         9477     9506      +29     
- Misses       3805     3864      +59

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov