Skip to content

Conversation

@samuelbray32
Copy link
Collaborator

@samuelbray32 samuelbray32 commented Oct 30, 2025

Description

  • Recent PR removed staticmethod flag on _logged_env_info
  • need to adjust _alter_spyglass_version to accomodate

Checklist:

  • If this PR should be accompanied by a release, I have updated the CITATION.cff
  • If this PR edits table definitions, I have included an alter snippet for release notes.
  • If this PR makes changes to position, I ran the relevant tests locally.
  • If this PR makes user-facing changes, I have added/edited docs/notebooks to reflect the changes
  • I have updated the CHANGELOG.md with PR number and description.

@samuelbray32 samuelbray32 requested a review from CBroz1 October 30, 2025 22:56
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.02%. Comparing base (8c6ad08) to head (fe8eacb).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/spyglass/utils/mixins/analysis.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1451      +/-   ##
==========================================
- Coverage   71.02%   71.02%   -0.01%     
==========================================
  Files         113      113              
  Lines       13088    13087       -1     
==========================================
- Hits         9296     9295       -1     
  Misses       3792     3792              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CBroz1
Copy link
Member

CBroz1 commented Oct 31, 2025

It's worth noting that this merging means it's not tested, and it probably should be. Out of scope for this PR

@CBroz1 CBroz1 merged commit 33f30f2 into master Oct 31, 2025
21 checks passed
@CBroz1 CBroz1 deleted the quickfix_analysis_method branch October 31, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants