Skip to content

Conversation

@samuelbray32
Copy link
Collaborator

@samuelbray32 samuelbray32 commented Nov 26, 2025

Description

Fixes #1410

  • transaction grouping in populate_all_common leads to long transaction times
  • tables like Lab often have pre-existing entries in database
  • Previously used skip_duplicates=True to avoid error
    • Led to long-held locks prevventing simultaneous session insertion by multiple users
  • This instead checks validity of duplicate and skips attempting to insert entirely if present
    • Should help avoid conflicting locks between users

Checklist:

  • NA If this PR should be accompanied by a release, I have updated the CITATION.cff
  • NA If this PR edits table definitions, I have included an alter snippet for release notes.
  • NA If this PR makes changes to position, I ran the relevant tests locally.
  • NA If this PR makes user-facing changes, I have added/edited docs/notebooks to reflect the changes
  • I have updated the CHANGELOG.md with PR number and description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conflicting row locks cause by skip_duplicates

2 participants