Skip to content

Conversation

@samuelbray32
Copy link
Collaborator

@samuelbray32 samuelbray32 commented Nov 26, 2025

Description

Issue:

  • Currently entries in any TimeIntervals table is inserted into IntervalList during IntervalList.insert_from_nwb_file
  • This scoops up entries from things like FranklabOptogeneticEpochs and names them uniformative things like interval 1
  • This then leads to errors when trying to identifying matching epochs during ingestion of TaskEpochs table

Fix:
Restricts ingestion to only entries from the time intervals table named epochs in the nwb file

Checklist:

  • NA If this PR should be accompanied by a release, I have updated the CITATION.cff
  • NA If this PR edits table definitions, I have included an alter snippet for release notes.
  • NA If this PR makes changes to position, I ran the relevant tests locally.
  • NA If this PR makes user-facing changes, I have added/edited docs/notebooks to reflect the changes
  • I have updated the CHANGELOG.md with PR number and description.

@samuelbray32 samuelbray32 changed the title only insert intervals from the epochs table Only insert intervals from the epochs table Nov 26, 2025
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.11%. Comparing base (32b6950) to head (8001dd4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1484      +/-   ##
==========================================
- Coverage   71.12%   71.11%   -0.02%     
==========================================
  Files         114      114              
  Lines       13306    13307       +1     
==========================================
- Hits         9464     9463       -1     
- Misses       3842     3844       +2     
Flag Coverage Δ
full-tests 71.11% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants